-
Notifications
You must be signed in to change notification settings - Fork 869
feat: async router #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: async router #379
Conversation
DeepCode's analysis on #11de79 found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
Thanks for the PR. You can run the tests with The port issue your running into are the |
@chimurai tests added :) |
Awesome! Could you update the README.md with a tiny async example. Just to indicate option.router
// Custom async router function
router: async function(req) {
return 'http://localhost:8004';
} |
@chimurai looks good? |
Thanks! Published beta version When it looks ok shortly, I'll publish 0.21.0 final |
hello,
this PR adds support for options.router for async handlers.
It came up in this issue: #153
I would be glad to also add tests, but it seems like instructions are missing since it expects a running server on port 8000/3000.. please provide and i'll complete the tests