Skip to content

Commit 00c7174

Browse files
rozelefacebook-github-bot
authored andcommitted
Add override to RCTHermesInstance destructor (facebook#48265)
Summary: Pull Request resolved: facebook#48265 For some clang warnings configurations, you may hit `-Winconsistent-missing-destructor-override` without this override modifier. ## Changelog [Internal] Reviewed By: cipolleschi Differential Revision: D67203040 fbshipit-source-id: 51f8f9bc4e45ebdb008dc440b779302b1103668a
1 parent 9a2b807 commit 00c7174

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class RCTHermesInstance : public JSRuntimeFactory {
3030
std::unique_ptr<JSRuntime> createJSRuntime(
3131
std::shared_ptr<MessageQueueThread> msgQueueThread) noexcept override;
3232

33-
~RCTHermesInstance(){};
33+
~RCTHermesInstance() override{};
3434

3535
private:
3636
CrashManagerProvider _crashManagerProvider;

0 commit comments

Comments
 (0)