Skip to content

Commit dc6b89c

Browse files
authored
adjust allowlist for urllib.response.addbase (python#13219)
I don't think we need a regex for just two items
1 parent 4aad825 commit dc6b89c

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

stdlib/@tests/stubtest_allowlists/common.txt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -548,11 +548,8 @@ types.ModuleType.__dict__ # read-only but not actually a property; stubtest thi
548548
types.ModuleType.__getattr__ # this doesn't exist at runtime
549549
unittest.runner._WritelnDecorator.flush # Methods that come from __getattr__() at runtime
550550
unittest.runner._WritelnDecorator.write # Methods that come from __getattr__() at runtime
551-
552-
# See comments in file. List out methods that are delegated by __getattr__ at runtime.
553-
# Used to make the relevant class satisfy BinaryIO interface.
554-
urllib.response.addbase.\w+
555-
551+
urllib.response.addbase.write # Methods that come from __getattr__() at runtime
552+
urllib.response.addbase.writelines # Methods that come from __getattr__() at runtime
556553
urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ # Args are passed as is to super, so super args are specified
557554
uuid.bytes_ # Attributes that are intended to be private
558555
uuid.int_ # Attributes that are intended to be private

0 commit comments

Comments
 (0)