Skip to content

Commit 89920bf

Browse files
Fixes #10 - IE/Edge source maps.
Enforces line break before source map comment. Why: * Edge / IE doesn't like source map comment in the same line as other content wheras other browsers don't complain.
1 parent 7b51e2a commit 89920bf

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

Diff for: History.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
[4.1.4 / 2017-xx-xx](https://github.com/jakubpawlowicz/clean-css-cli/compare/v4.1.3...4.1)
2+
==================
3+
4+
* Fixed issue [#10](https://github.com/jakubpawlowicz/clean-css-cli/issues/10) - IE/Edge source maps.
5+
16
[4.1.3 / 2017-05-18](https://github.com/jakubpawlowicz/clean-css-cli/compare/v4.1.2...v4.1.3)
27
==================
38

Diff for: index.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ var commands = require('commander');
66
var glob = require('glob');
77

88
var COMPATIBILITY_PATTERN = /([\w\.]+)=(\w+)/g;
9+
var lineBreak = require('os').EOL;
910

1011
function cli(process, beforeMinifyCallback) {
1112
var packageConfig = fs.readFileSync(path.join(__dirname, 'package.json'));
@@ -245,7 +246,7 @@ function minify(process, beforeMinifyCallback, options, debugMode, removeInlined
245246

246247
if (minified.sourceMap) {
247248
mapFilename = path.basename(options.output) + '.map';
248-
output(process, options, minified.styles + '/*# sourceMappingURL=' + mapFilename + ' */');
249+
output(process, options, minified.styles + lineBreak + '/*# sourceMappingURL=' + mapFilename + ' */');
249250
outputMap(options, minified.sourceMap, mapFilename);
250251
} else {
251252
output(process, options, minified.styles);

Diff for: test/binary-test.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ var path = require('path');
66
var url = require('url');
77

88
var httpProxy = require('http-proxy');
9+
var lineBreak = require('os').EOL;
910
var SourceMapConsumer = require('source-map').SourceMapConsumer;
1011
var vows = require('vows');
1112

@@ -478,7 +479,7 @@ vows.describe('cleancss')
478479
.addBatch({
479480
'source maps - output file': binaryContext('--source-map -o ./reset.min.css ./test/fixtures/reset.css', {
480481
'includes map in minified file': function () {
481-
assert.include(fs.readFileSync('./reset.min.css', 'utf-8'), '/*# sourceMappingURL=reset.min.css.map */');
482+
assert.include(fs.readFileSync('./reset.min.css', 'utf-8'), lineBreak + '/*# sourceMappingURL=reset.min.css.map */');
482483
},
483484
'creates a map file': function () {
484485
assert.isTrue(fs.existsSync('./reset.min.css.map'));
@@ -572,7 +573,7 @@ vows.describe('cleancss')
572573
.addBatch({
573574
'source maps - with input source map': binaryContext('--source-map -o ./import.min.css ./test/fixtures/source-maps/import.css', {
574575
'includes map in minified file': function () {
575-
assert.include(fs.readFileSync('./import.min.css', 'utf-8'), '/*# sourceMappingURL=import.min.css.map */');
576+
assert.include(fs.readFileSync('./import.min.css', 'utf-8'), lineBreak + '/*# sourceMappingURL=import.min.css.map */');
576577
},
577578
'includes right content in map file': function () {
578579
var sourceMap = new SourceMapConsumer(fs.readFileSync('./import.min.css.map', 'utf-8'));
@@ -590,7 +591,7 @@ vows.describe('cleancss')
590591
.addBatch({
591592
'source maps - with input source map and source inlining': binaryContext('--source-map --source-map-inline-sources -o ./import-inline.min.css ./test/fixtures/source-maps/import.css', {
592593
'includes map in minified file': function () {
593-
assert.include(fs.readFileSync('./import-inline.min.css', 'utf-8'), '/*# sourceMappingURL=import-inline.min.css.map */');
594+
assert.include(fs.readFileSync('./import-inline.min.css', 'utf-8'), lineBreak + '/*# sourceMappingURL=import-inline.min.css.map */');
594595
},
595596
'includes embedded sources': function () {
596597
var sourceMap = new SourceMapConsumer(fs.readFileSync('./import-inline.min.css.map', 'utf-8'));

0 commit comments

Comments
 (0)