Merge pull request scaleway#69 from terraform-providers/server-validation

r/server: validate instance type availability

Author: nicolai86

scaleway/resource_server.go

@@ -179,6 +179,20 @@ func resourceScalewayServerCreate(d *schema.ResourceData, m interface{}) error {
 	req.DynamicIPRequired = Bool(d.Get("dynamic_ip_required").(bool))
 	req.CommercialType = d.Get("type").(string)
 
+	availabilities, err := scaleway.GetServerAvailabilities()
+	if err != nil {
+		log.Printf("[DEBUG] Unable to fetch server availability; won't validate availability: %q\n", err.Error())
+	} else {
+		typeAvailability, ok := availabilities[req.CommercialType]
+		if !ok {
+			// this will most likely happen for new instance types
+			log.Printf("[DEBUG] no server availability for type %q. Ignoring\n", req.CommercialType)
+		}
+		if typeAvailability.Availability == api.InstanceTypeShortage {
+			return fmt.Errorf("InstanceType %s is currently out of stock", req.CommercialType)
+		}
+	}
+
 	if bootscript, ok := d.GetOk("bootscript"); ok {
 		req.Bootscript = String(bootscript.(string))
 	}

vendor/github.com/nicolai86/scaleway-sdk/availability.go

@@ -570,10 +570,10 @@
 			"revisionTime": "2016-10-03T17:45:16Z"
 		},
 		{
-			"checksumSHA1": "5PC3eHJZwTMQyGJltpcIJp/aCNw=",
+			"checksumSHA1": "ucJEyEBIAPbSsctcjxHTqN/1aoo=",
 			"path": "github.com/nicolai86/scaleway-sdk",
-			"revision": "4871b0a66c85ce1a78bb5d8a62714ed1a5669650",
-			"revisionTime": "2018-05-12T06:04:43Z"
+			"revision": "a7b61129ca818b3a2d1ebb3d276ed82b5b7eabfe",
+			"revisionTime": "2018-06-24T01:24:03Z"
 		},
 		{
 			"checksumSHA1": "u5s2PZ7fzCOqQX7bVPf9IJ+qNLQ=",