Skip to content

Commit c1f7cd5

Browse files
committed
chore: remove obsolete comments on config defaults
following kubernetes#11819, some defaults became obsolete. I think removing the comment altogether prevents us from forgetting to update it in the future. the source code should suffice for anyone willing to check the default
1 parent aa2d164 commit c1f7cd5

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

internal/ingress/controller/config/config.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,10 @@ type Configuration struct {
9797
// AllowCrossNamespaceResources enables users to consume cross namespace resource on annotations
9898
// Case disabled, attempts to use secrets or configmaps from a namespace different from Ingress will
9999
// be denied
100-
// This value will default to `false` on future releases
101100
AllowCrossNamespaceResources bool `json:"allow-cross-namespace-resources"`
102101

103102
// AnnotationsRiskLevel represents the risk accepted on an annotation. If the risk is, for instance `Medium`, annotations
104103
// with risk High and Critical will not be accepted.
105-
// Default Risk is Critical by default, but this may be changed in future releases
106104
AnnotationsRiskLevel string `json:"annotations-risk-level"`
107105

108106
// AnnotationValueWordBlocklist defines words that should not be part of an user annotation value

internal/ingress/defaults/main.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ type SecurityConfiguration struct {
195195
// AllowCrossNamespaceResources enables users to consume cross namespace resource on annotations
196196
// Case disabled, attempts to use secrets or configmaps from a namespace different from Ingress will
197197
// be denied
198-
// This valid will default to `false` on future releases
199198
AllowCrossNamespaceResources bool `json:"allow-cross-namespace-resources"`
200199

201200
// AnnotationsRiskLevel represents the risk accepted on an annotation. If the risk is, for instance `Medium`, annotations

0 commit comments

Comments
 (0)