Skip to content

Commit 02b00c1

Browse files
committed
chore(clerk-js): Centralize cookie code into single module
1 parent 36ab5b2 commit 02b00c1

14 files changed

+21
-23
lines changed

packages/clerk-js/src/core/__tests__/clerk.redirects.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import type { DevBrowser } from '../auth/devBrowser';
12
import { Clerk } from '../clerk';
2-
import type { DevBrowser } from '../devBrowser';
33
import type { DisplayConfig } from '../resources/internal';
44
import { Client, Environment } from '../resources/internal';
55

@@ -10,7 +10,7 @@ jest.mock('../resources/Client');
1010
jest.mock('../resources/Environment');
1111

1212
// Because Jest, don't ask me why...
13-
jest.mock('../devBrowser', () => ({
13+
jest.mock('../auth/devBrowser', () => ({
1414
createDevBrowser: (): DevBrowser => ({
1515
clear: jest.fn(),
1616
setup: jest.fn(),

packages/clerk-js/src/core/services/authentication/SessionCookiePoller.ts renamed to packages/clerk-js/src/core/auth/SessionCookiePoller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { createWorkerTimers } from '@clerk/shared';
22

3-
import { SafeLock } from '../../../utils';
3+
import { SafeLock } from './safeLock';
44

55
const REFRESH_SESSION_TOKEN_LOCK_KEY = 'clerk.lock.refreshSessionToken';
66
const INTERVAL_IN_MS = 5 * 1000;

packages/clerk-js/src/core/services/authentication/SessionCookieService.ts renamed to packages/clerk-js/src/core/auth/SessionCookieService.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { is4xxError, isClerkAPIResponseError, isNetworkError } from '@clerk/shared/error';
22
import type { Clerk, EnvironmentResource, SessionResource, TokenResource } from '@clerk/types';
33

4-
import { inBrowser } from '../../../utils';
5-
import { setClientUatCookie } from '../../../utils/cookies/clientUat';
6-
import { removeSessionCookie, setSessionCookie } from '../../../utils/cookies/session';
7-
import { clerkCoreErrorTokenRefreshFailed } from '../../errors';
8-
import { eventBus, events } from '../../events';
4+
import { inBrowser } from '../../utils';
5+
import { clerkCoreErrorTokenRefreshFailed } from '../errors';
6+
import { eventBus, events } from '../events';
7+
import { setClientUatCookie } from './cookies/clientUat';
8+
import { removeSessionCookie, setSessionCookie } from './cookies/session';
99
import { SessionCookiePoller } from './SessionCookiePoller';
1010

1111
export class SessionCookieService {

packages/clerk-js/src/core/__tests__/devBrowser.test.ts renamed to packages/clerk-js/src/core/auth/__tests__/devBrowser.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import type { FapiClient } from '../../fapiClient';
12
import { createDevBrowser } from '../devBrowser';
2-
import type { FapiClient } from '../fapiClient';
33

44
type RecursivePartial<T> = {
55
[P in keyof T]?: RecursivePartial<T[P]>;

packages/clerk-js/src/utils/cookies/clientUat.ts renamed to packages/clerk-js/src/core/auth/cookies/clientUat.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import { createCookieHandler } from '@clerk/shared/cookie';
22
import { addYears } from '@clerk/shared/date';
33
import type { ClientResource } from '@clerk/types';
44

5-
import { inCrossOriginIframe } from '../../utils';
6-
import { getCookieDomain } from './getCookieDomain';
5+
import { inCrossOriginIframe } from '../../../utils';
6+
import { getCookieDomain } from '../getCookieDomain';
77

88
const CLIENT_UAT_COOKIE_NAME = '__client_uat';
99

packages/clerk-js/src/utils/cookies/devBrowser.ts renamed to packages/clerk-js/src/core/auth/cookies/devBrowser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { createCookieHandler } from '@clerk/shared/cookie';
22
import { addYears } from '@clerk/shared/date';
33
import { DEV_BROWSER_JWT_KEY } from '@clerk/shared/devBrowser';
44

5-
import { inCrossOriginIframe } from '../../utils';
5+
import { inCrossOriginIframe } from '../../../utils';
66

77
export const devBrowserCookie = createCookieHandler(DEV_BROWSER_JWT_KEY);
88

packages/clerk-js/src/utils/cookies/session.ts renamed to packages/clerk-js/src/core/auth/cookies/session.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { createCookieHandler } from '@clerk/shared/cookie';
22
import { addYears } from '@clerk/shared/date';
33

4-
import { inCrossOriginIframe } from '../../utils';
4+
import { inCrossOriginIframe } from '../../../utils';
55

66
const SESSION_COOKIE_NAME = '__session';
77

packages/clerk-js/src/core/devBrowser.ts renamed to packages/clerk-js/src/core/auth/devBrowser.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ import { DEV_BROWSER_JWT_HEADER, extractDevBrowserJWTFromURL, setDevBrowserJWTIn
22
import { parseErrors } from '@clerk/shared/error';
33
import type { ClerkAPIErrorJSON } from '@clerk/types';
44

5-
import { isDevOrStagingUrl } from '../utils';
6-
import { getDevBrowserCookie, removeDevBrowserCookie, setDevBrowserCookie } from '../utils/cookies/devBrowser';
7-
import { clerkErrorDevInitFailed } from './errors';
8-
import type { FapiClient } from './fapiClient';
5+
import { isDevOrStagingUrl } from '../../utils';
6+
import { clerkErrorDevInitFailed } from '../errors';
7+
import type { FapiClient } from '../fapiClient';
8+
import { getDevBrowserCookie, removeDevBrowserCookie, setDevBrowserCookie } from './cookies/devBrowser';
99

1010
export interface DevBrowser {
1111
clear(): void;

packages/clerk-js/src/core/clerk.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,13 @@ import {
8585
windowNavigate,
8686
} from '../utils';
8787
import { assertNoLegacyProp } from '../utils/assertNoLegacyProp';
88-
import { getClientUatCookie } from '../utils/cookies/clientUat';
8988
import { memoizeListenerCallback } from '../utils/memoizeStateListenerCallback';
9089
import { RedirectUrls } from '../utils/redirectUrls';
90+
import { getClientUatCookie } from './auth/cookies/clientUat';
91+
import type { DevBrowser } from './auth/devBrowser';
92+
import { createDevBrowser } from './auth/devBrowser';
93+
import { SessionCookieService } from './auth/SessionCookieService';
9194
import { CLERK_SATELLITE_URL, CLERK_SYNCED, ERROR_CODES } from './constants';
92-
import type { DevBrowser } from './devBrowser';
93-
import { createDevBrowser } from './devBrowser';
9495
import {
9596
clerkErrorInitFailed,
9697
clerkInvalidSignInUrlFormat,
@@ -111,7 +112,6 @@ import {
111112
Environment,
112113
Organization,
113114
} from './resources/internal';
114-
import { SessionCookieService } from './services';
115115
import { warnings } from './warnings';
116116

117117
export type ClerkCoreBroadcastChannelEvent = { type: 'signout' };

packages/clerk-js/src/core/services/index.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/clerk-js/src/utils/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export * from './props';
1717
export * from './queryStateParams';
1818
export * from './querystring';
1919
export * from './runtime';
20-
export * from './safeLock';
2120
export * from './url';
2221
export * from './web3';
2322
export * from './windowNavigate';

0 commit comments

Comments
 (0)