Skip to content

Commit 4c7d111

Browse files
committed
Fix waitForAppUrl race condition
1 parent ad543f3 commit 4c7d111

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/ci.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ jobs:
130130

131131
integration-tests:
132132
name: Integration Tests
133-
needs: formatting-linting
133+
# needs: formatting-linting
134134
runs-on: ${{ vars.RUNNER_LARGE || 'ubuntu-latest-l' }}
135135
timeout-minutes: ${{ vars.TIMEOUT_MINUTES_LONG && fromJSON(vars.TIMEOUT_MINUTES_LONG) || 15 }}
136136

@@ -191,11 +191,11 @@ jobs:
191191
if: ${{ steps.task-status.outputs.affected == '1' }}
192192
working-directory: ${{runner.temp}}
193193
run: mkdir clerk-js && cd clerk-js && npm init -y && npm install @clerk/clerk-js
194-
194+
195195
- name: Copy components @clerk/astro
196196
if: ${{ matrix.test-name == 'astro' }}
197197
run: cd packages/astro && npm run copy:components
198-
198+
199199
- name: Write all ENV certificates to files in integration/certs
200200
if: ${{ steps.task-status.outputs.affected == '1' }}
201201
uses: actions/github-script@v7

integration/playwright.config.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ import * as path from 'path';
88

99
config({ path: path.resolve(__dirname, '.env.local') });
1010

11-
const numAvailableWorkers = os.cpus().length - 1;
11+
const numAvailableWorkers = Math.floor(os.cpus().length / 2) + 1;
12+
console.log(`Running tests using ${numAvailableWorkers} workers`);
1213

1314
export const common: PlaywrightTestConfig = {
1415
testDir: './tests',
@@ -18,7 +19,7 @@ export const common: PlaywrightTestConfig = {
1819
retries: process.env.CI ? 2 : 0,
1920
timeout: 90000,
2021
maxFailures: process.env.CI ? 1 : undefined,
21-
workers: process.env.CI ? numAvailableWorkers : '50%',
22+
workers: process.env.CI ? numAvailableWorkers : '70%',
2223
reporter: process.env.CI ? 'line' : 'list',
2324
use: {
2425
ignoreHTTPSErrors: true,

0 commit comments

Comments
 (0)