Skip to content

Update the test middleware for nREPL 0.6 #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbatsov opened this issue Dec 29, 2018 · 2 comments · Fixed by #590
Closed

Update the test middleware for nREPL 0.6 #581

bbatsov opened this issue Dec 29, 2018 · 2 comments · Fixed by #590

Comments

@bbatsov
Copy link
Member

bbatsov commented Dec 29, 2018

nREPL 0.6 features a simplified and more robust evaluation model (see nrepl/nrepl#98), but this break the current implementation of the test middleware, which was making some assumptions about the internals of the eval middleware.

This ticket is a reminder to address this before nREPL 0.6 is released.

@jeffvalk would you like to tackle this? The updates should be pretty simple - seems to me that only the with-interruptible-eval macro should be updated.

@jeffvalk
Copy link
Contributor

jeffvalk commented Jan 3, 2019

@bbatsov I'm not sure how soon I'd be able to get to this -- particularly if it's a research item.

@bbatsov
Copy link
Member Author

bbatsov commented Jan 3, 2019

I think it's just a matter of changing the use of queue-eval to the new exec as @cgrand did in the PR where he reworked the eval thread management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants