Skip to content

Breaking change of nrepl.middleware.pr-values to nrepl.middleware.print in nRepl 0.6.0 #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danieroux opened this issue Feb 9, 2019 · 2 comments
Closed

Breaking change of nrepl.middleware.pr-values to nrepl.middleware.print in nRepl 0.6.0 #593

danieroux opened this issue Feb 9, 2019 · 2 comments

Comments

@danieroux
Copy link

Existing middleware descriptors whose :requires set contains #'pr-values should instead use #'wrap-print according to https://github.com/nrepl/nrepl/releases/tag/0.6.0

And cider-nrepl is not using wrap-print yet:

cider-nrepl/src/cider/nrepl.clj

Line 9 in d9be18e

[nrepl.middleware.pr-values :refer [pr-values]]

So bumping nRepl to 0.6.0 breaks my cider-nrepl.
@danieroux
Copy link
Author

Fixed by open pull request #590

@cichli
Copy link
Member

cichli commented Feb 11, 2019

Thanks – I've released 0.21.0 now, which supports nREPL 0.6.0. Client release will follow once clojure-emacs/cider#2579 is merged.

@cichli cichli closed this as completed Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danieroux @cichli