Skip to content

Commit a86a676

Browse files
committed
Update the test/lint commands in the contribution templates
1 parent ffe5bac commit a86a676

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ reliably would also make a huge difference.
3737
* Use a topic branch to easily amend a pull request later, if necessary.
3838
* Use the same coding conventions as the rest of the project.
3939
* Verify your Emacs Lisp code with `checkdoc` (<kbd>C-c ? d</kbd>).
40-
* Make sure that the unit tests are passing (`make test`).
40+
* Make sure that the unit tests are passing (`eldev test`).
41+
* Make sure that there are no lint warnings (`eldev lint`).
4142
* Write [good commit messages][3].
4243
* Mention related tickets in the commit messages (e.g. `[Fix #N] Add command ...`).
4344
* Update the [changelog][6].

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ by checking the relevant checkboxes):
88

99
- [ ] The commits are consistent with our [contribution guidelines](../blob/master/.github/CONTRIBUTING.md)
1010
- [ ] You've added tests (if possible) to cover your change(s)
11-
- [ ] All tests are passing (`make test`)
12-
- [ ] All code passes the linter (`make lint`) which is based on [`elisp-lint`](https://github.com/gonewest818/elisp-lint) and includes
11+
- [ ] All tests are passing (`eldev test`)
12+
- [ ] All code passes the linter (`eldev lint`) which is based on [`elisp-lint`](https://github.com/gonewest818/elisp-lint) and includes
1313
- [byte-compilation](https://www.gnu.org/software/emacs/manual/html_node/elisp/Byte-Compilation.html), [`checkdoc`](https://www.gnu.org/software/emacs/manual/html_node/elisp/Tips.html), [check-declare](https://www.gnu.org/software/emacs/manual/html_node/elisp/Declaring-Functions.html), packaging metadata, indentation, and trailing whitespace checks.
1414
- [ ] You've updated the [changelog](../blob/master/CHANGELOG.md) (if adding/changing user-visible functionality)
1515
- [ ] You've updated the [user manual](../blob/master/doc) (if adding/changing user-visible functionality)

0 commit comments

Comments
 (0)