[Fix #309] am uses alias for fully qualified ns

Author: expez

CHANGELOG.md

@@ -12,6 +12,7 @@
 
 ### Bugs fixed
 
+- [#309](https://github.com/clojure-emacs/clj-refactor.el/issues/309) `*data-readers*` `am` creates alias for fully-qualified symbols.
 - [#320](https://github.com/clojure-emacs/clj-refactor.el/issues/320) `*data-readers*` ignored when searching for macros.
 
 ## 2.2.0

clj-refactor.el

@@ -985,18 +985,18 @@ If CLJS? is T we insert in the cljs part of the ns declaration."
 (defun cljr--cljs-file-p (&optional buf)
   "Is BUF, or the current buffer, visiting a cljc file?"
   (s-equals-p (file-name-extension (buffer-file-name (or buf (current-buffer))))
-             "cljs"))
+              "cljs"))
 
 (defun cljr--cljc-file-p (&optional buf)
   "Is BUF, or the current buffer, visiting a cljc file?"
   (s-equals-p (file-name-extension (buffer-file-name (or buf (current-buffer))))
-             "cljc"))
+              "cljc"))
 
 (defun cljr--clj-file-p (&optional buf)
   "Is BUF, or the current buffer, visiting a clj file?"
   (or (eq major-mode 'clojure-mode)
       (s-equals-p (file-name-extension (buffer-file-name (or buf (current-buffer))))
-                 "clj")))
+                  "clj")))
 
 (defun cljr--add-test-declarations ()
   (save-excursion
@@ -2138,8 +2138,8 @@ FEATURE is either :clj or :cljs."
         (if (cljr--point-in-reader-conditional-p)
             (cljr--point-in-reader-conditional-branch-p :clj)
           (s-equals-p (cljr--prompt-user-for "Language context at point? "
-                                            (list "clj" "cljs"))
-                     "clj")))))
+                                             (list "clj" "cljs"))
+                      "clj")))))
 
 (defun cljr--aget (map key)
   (cdr (assoc key map)))
@@ -2867,7 +2867,7 @@ Also adds the alias prefix to all occurrences of public symbols in the namespace
   (cljr--ensure-op-supported "find-used-publics")
   (let ((filename (buffer-file-name)))
     (let* ((alias (or alias
-                    (cljr--prompt-user-for (format "alias for [%s]: " ns))))
+                      (cljr--prompt-user-for (format "alias for [%s]: " ns))))
            (request
             (cljr--create-msg "find-used-publics"
                               "used-ns" ns
@@ -2970,15 +2970,21 @@ Inspect SYMBOL, the thing at point, to find out whether we have
 to create an alias or refer."
   (save-excursion
     (cljr--insert-in-ns ":require")
-    (let ((missing (format "%s" missing-symbol))
-          (alias? (cljr--qualified-symbol-p symbol)))
-      (if alias?
-          (cljr--insert-libspec-verbosely (format "[%s :as %s]" missing
-                                                  (cljr--symbol-prefix symbol)))
-        (if (and (s-contains-p "." missing)
-                 (s-uppercase? (s-left 1 (cljr--symbol-suffix missing))))
-            (cljr--insert-libspec-verbosely  (cljr--symbol-prefix symbol))
-          (cljr--insert-libspec-verbosely (format "[%s :refer [%s]]"
+    (let* ((missing (format "%s" missing-symbol))
+           (alias? (cljr--qualified-symbol-p symbol)))
+      (cond
+       ;;  defrecord / deftype where the package must be required
+       ((and (s-contains-p "." missing)
+             (s-uppercase? (s-left 1 (cljr--symbol-suffix symbol))))
+        (cljr--insert-libspec-verbosely (cljr--symbol-prefix missing)))
+       ;; Fully qualified symbol
+       ((and (cljr--qualified-symbol-p symbol)
+             (string= (cljr--symbol-prefix symbol) missing))
+        (cljr--insert-libspec-verbosely missing))
+       (alias?
+        (cljr--insert-libspec-verbosely (format "[%s :as %s]" missing
+                                                (cljr--symbol-prefix symbol))))
+       (t (cljr--insert-libspec-verbosely (format "[%s :refer [%s]]"
                                                   missing symbol)))))))
 
 (defun cljr--add-missing-libspec (symbol candidates)
@@ -2993,8 +2999,8 @@ to create an alias or refer."
            ;; In the line below we're assuming that all clojure code
            ;; will prefer - over _ when naming namespaces :(
            (progn (cljr--insert-missing-require
-                   (s-replace "_" "-" (format "%s" missing-symbol))
-                   missing-symbol)
+                   symbol
+                   (s-replace "_" "-" (format "%s" missing-symbol)))
                   (cljr--insert-missing-import missing-symbol)))
           ((eq type :class) (cljr--insert-missing-import missing-symbol))
           (t (error (format "Uknown type %s" type))))))

features/add-missing-libspec.feature

@@ -43,3 +43,11 @@ Feature: resolve-missing; nrepl middleware response mocked
       (:require modular.ring)
       (:import modular.ring.WebrequestHandler)
     """
+
+  Scenario: Require fully qualified without aliasing #309
+    Given I call the add-missing-libspec callback directly with mock data to require schema.test
+    Then I should see:
+    """
+    (ns example.core
+      (:require schema.test))
+    """

features/step-definitions/clj-refactor-steps.el

@@ -112,6 +112,12 @@
           (list (cljr--make-seeded-hash-table
                  :name 'modular.ring.WebrequestHandler :type :type)))))
 
+(Given "^I call the add-missing-libspec callback directly with mock data to require schema.test"
+       (lambda ()
+         (cljr--add-missing-libspec "schema.test/validate-schemas"
+                                    (list (cljr--make-seeded-hash-table
+                                           :name 'schema.test :type :ns)))))
+
 (Then "^the file should be named \"\\([^\"]+\\)\"$"
       (lambda (file-name-postfix)
         (assert (s-ends-with? file-name-postfix (buffer-file-name)) nil "Expected %S to end with %S" (buffer-file-name) file-name-postfix)))