[Fix #216] Better auto-ns for cljc files

There is no :refer :all in cljs:

- Require the ns under test :as sut
- Require clojure.test and cljs.test :as t for symmetry

Author: expez

CHANGELOG.md

@@ -8,6 +8,7 @@
 
 ### Changes
 
+- [#216](https://github.com/clojure-emacs/clj-refactor.el/issues/216) Teach our automatic ns generator about cljc files.
 - Teach `cljr-extract-constant` about the `^:const` hint to the compiler.
 - Use yasnippet for placeholder parameters in `cljr-create-fn-from-example`
 - Highlight the function be promoted with overlays in `cljr-promote-function`.

clj-refactor.el

@@ -776,19 +776,31 @@ Signal an error if it is not supported."
     (when src-ns
       (mapconcat 'identity (append (butlast ns-chunks) (list src-ns)) "."))))
 
+(defun cljr--cljc-file? (&optional buf)
+  "Is buf, or current buffer, visiting a cljc file?"
+  (s-ends-with? ".cljc" (buffer-file-name (or buf (current-buffer)))))
+
 (defun cljr--add-test-use-declarations ()
   (save-excursion
     (let* ((ns (clojure-find-ns))
            (source-ns (cljr--find-source-ns-of-test-ns ns (buffer-file-name))))
       (cljr--insert-in-ns ":require")
       (when source-ns
-        (insert "[" source-ns " :refer :all]"))
+        (if (cljr--cljc-file?)
+            ;; no :refer :all in cljs
+            (insert "[" source-ns " :as :sut]")
+          (insert "[" source-ns " :refer :all]")))
       (cljr--insert-in-ns ":require")
-      (insert "[" (cond
-                   ((cljr--project-depends-on-p "midje") "midje.sweet")
-                   ((cljr--project-depends-on-p "expectations") "expectations")
-                   (t "clojure.test"))
-              " :refer :all]"))))
+      (insert (cond
+               ((cljr--project-depends-on-p "midje")
+                "[midje.sweet :refer :all]")
+               ((cljr--project-depends-on-p "expectations")
+                "[expectations :refer :all]")
+               ((cljr--cljc-file?)
+                "#?(:clj [clojure.test :as t]
+:cljs [cljs.test :as t :include-macros true])")
+               (t "[clojure.test :refer :all]"))))
+    (indent-region (point-min) (point-max))))
 
 (defun cljr--in-tests-p ()
   "Check whether the current file is a test file.

features/auto-ns.feature

@@ -64,3 +64,13 @@ Feature: Add namespace to blank .clj files
       (:require [cljr.core :refer :all]
                 [midje.sweet :refer :all]))
     """
+
+  Scenario: cljc file
+    When I open file "tmp/test/cljr/core_test.cljc"
+    Then I should see:
+    """
+    (ns cljr.core-test
+      (:require [cljr.core :as sut]
+                #?(:clj [clojure.test :as t]
+                        :cljs [cljs.test :as t :include-macros true])))
+    """

features/support/env.el

@@ -35,20 +35,29 @@
  (cljr-add-keybindings-with-prefix "C-!")
  (add-hook 'clojure-mode-hook (lambda () (clj-refactor-mode))))
 
-(Before
- (save-all-buffers-dont-ask)
- (kill-matching-buffers-dont-ask "clj")
- (setq cljr-use-multiple-cursors t))
+(defun kill-matching-buffers-dont-ask (regexp &optional internal-too)
+  (dolist (buffer (buffer-list))
+    (let ((name (buffer-name buffer)))
+      (when (and name (not (string-equal name ""))
+                 (or internal-too (/= (aref name 0) ?\s))
+                 (string-match regexp name))
+        (kill-buffer buffer)))))
 
 (defun save-all-buffers-dont-ask ()
   (dolist (buffer (buffer-list))
     (with-current-buffer buffer
       (let ((filename (buffer-file-name)))
         (when (and filename
                    (or (file-exists-p filename)
-                       (s-ends-with? ".clj" filename)))
+                       (s-ends-with? ".clj" filename)
+                       (s-ends-with? ".cljc" filename)))
           (save-buffer))))))
 
+(Before
+ (save-all-buffers-dont-ask)
+ (kill-matching-buffers-dont-ask "cljc?")
+ (setq cljr-use-multiple-cursors t))
+
 (defun kill-matching-buffers-dont-ask (regexp &optional internal-too)
   (dolist (buffer (buffer-list))
     (let ((name (buffer-name buffer)))
@@ -59,7 +68,7 @@
 
 (After
  (save-all-buffers-dont-ask)
- (kill-matching-buffers-dont-ask "clj")
+ (kill-matching-buffers-dont-ask "cljc?")
  (delete-directory (expand-file-name "tmp" clj-refactor-root-path) t))
 
 (Teardown