Prefer find-file-noselect to with-temp-file (#503)

`with-temp-file` causes `(buffer-file-name)` to return nil which is the root cause of #139.

Additionally, `cljr--update-file` does not leave files open (unless they were alrady open), improving performance / UX.

Fixes #139

Author: vemv

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- [#139](https://github.com/clojure-emacs/clj-refactor.el/issues/139): avoid a repeated prompt when using `(cljr-project-clean)`.
+
 ## 3.0.0 (2021-10-25)
 
 - [#483](https://github.com/clojure-emacs/clj-refactor.el/issues/483): Improve performance of `cljr-slash` when typing fraction literals.

clj-refactor.el

@@ -337,19 +337,18 @@ Otherwise open the file and do the changes non-interactively."
   (declare (debug (form body))
            (indent 1))
   (let ((fn (make-symbol "filename"))
-        (bf (make-symbol "buffer")))
+        (bf (make-symbol "buffer"))
+        (wo (make-symbol "was-open")))
     `(let* ((,fn ,filename)
-            (,bf (get-file-buffer ,fn)))
-       (if ,bf
-           (progn
-             (set-buffer ,bf)
-             ,@body
-             (save-buffer))
-         (with-temp-file ,fn
-           (insert-file-contents ,fn)
-           (delay-mode-hooks
-             (clojure-mode)
-             ,@body))))))
+            (,wo (get-file-buffer ,fn))
+            (,bf (find-file-noselect ,fn)))
+       (when ,bf
+         (set-buffer ,bf)
+         ,@body
+         (save-buffer)
+         (when (not ,wo)
+           ;; Don't accumulate open buffers, since this can slow down Emacs for large projects:
+           (kill-buffer))))))
 
 (define-key clj-refactor-map [remap paredit-raise-sexp] 'cljr-raise-sexp)
 (define-key clj-refactor-map [remap paredit-splice-sexp-killing-backward] 'cljr-splice-sexp-killing-backward)