[Fix #371] Teach cljr-slash about in-ns

`cljr-slash` should not do its autoinsert require magic in case
the namepace is defined in the buffer by a `(in-ns ...)` form.

Author: benedekfazekas

CHANGELOG.md

@@ -33,6 +33,7 @@
 - [#341](https://github.com/clojure-emacs/clj-refactor.el/issues/341) Avoid creating circular dependencies with move form when source namespace refers to the target namespace with a require.
 - [refactor-nrepl#183](https://github.com/clojure-emacs/refactor-nrepl/issues/183) Applied conversion between Unix-like path generated by Emacs under Cygwin and Windows-like path required by nREPL. Cider functions `cider-to-nrepl-filename-function` and `cider-from-nrepl-filename-function` are used.
 - Fix `cljr--normalize-symbol-name` when the symbol name starts with `#'`.
+- [#371](https://github.com/clojure-emacs/clj-refactor.el/issues/371) Stop `cljr-slash` messing up `(in-ns ...)` forms
 
 ## 2.2.0
 

clj-refactor.el

@@ -894,11 +894,25 @@ Please, install (or update) refactor-nrepl %s and restart the REPL."
 ;; ------ ns statements -----------
 
 (defun cljr--goto-ns ()
+  "Go to the first namespace defining form in the buffer."
   (goto-char (point-min))
   (if (re-search-forward clojure-namespace-name-regex nil t)
       (cljr--goto-toplevel)
     (error "No namespace declaration found")))
 
+(defun cljr--goto-closest-ns ()
+  "Go to the closest namespace defining form.
+Go to the namespace form closest to point and above it.  If there is
+no namespace form above point, return the first one in the buffer."
+  (save-restriction
+    (widen)
+    ;; The closest ns form above point.
+    (when (or (re-search-backward clojure-namespace-name-regex nil t)
+              ;; Or any form at all.
+              (and (goto-char (point-min))
+                   (re-search-forward clojure-namespace-name-regex nil t)))
+      (cljr--goto-toplevel))))
+
 (defun cljr--goto-cljs-branch ()
   "Move POINT to the cljs branch of the reader conditional following point."
   (if (re-search-forward ":cljs" (cljr--point-after 'paredit-forward) :no-error)
@@ -1858,6 +1872,11 @@ the alias in the project."
       (paredit-forward-down)
       (looking-at-p ":keys"))))
 
+(defun cljr--in-ns-above-point-p ()
+  (save-excursion
+    (cljr--goto-closest-ns)
+    (looking-at-p "(\\s-*in-ns")))
+
 ;;;###autoload
 (defun cljr-slash ()
   "Inserts / as normal, but also checks for common namespace shorthands to require.
@@ -1867,7 +1886,8 @@ command will add the corresponding require statement to the ns
 form."
   (interactive)
   (insert "/")
-  (unless (cljr--in-map-destructuring?)
+  (unless (or (cljr--in-map-destructuring?)
+              (cljr--in-ns-above-point-p))
     (when-let (aliases (and cljr-magic-requires
 			    (not (cider-in-comment-p))
 			    (not (cider-in-string-p))

features/magic-requires.feature

@@ -23,6 +23,22 @@ Feature: Magic requires
     (set/union)
     """
 
+  Scenario: Require is not inserted automagically when in-ns is used
+    When I insert:
+    """
+    (in-ns 'cljr.core)
+
+    (set)
+    """
+    And I place the cursor after "set"
+    And I type "/union"
+    Then I should see:
+    """
+    (in-ns 'cljr.core)
+
+    (set/union)
+    """
+
   Scenario: Require is inserted automagically after getting suggestions from middleware
     When I insert:
     """