Skip to content

Commit fd18522

Browse files
committed
Fallback to java 11 for javadocs
1 parent 1cdb843 commit fd18522

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/orchard/java.clj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,8 @@
373373
;; 8. clojure 1.10.1 doesn't have 13. We just backport them
374374
;; regardless of clojure version
375375
(zipmap ["java." "javax." "org.ietf.jgss." "org.omg." "org.w3c.dom." "org.xml.sax"]
376-
(repeat (backported-javadoc-bases misc/java-api-version)))))
376+
(repeat (or (backported-javadoc-bases misc/java-api-version)
377+
(backported-javadoc-bases 11))))))
377378
path))
378379

379380
;;; ## Initialization

test/orchard/java_test.clj

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,12 @@
294294
(is (= "http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/lambda/AWSLambdaClient.html"
295295
(get-url ['com.amazonaws.services.lambda.AWSLambdaClient])))
296296
(is (= "https://kafka.apache.org/090/javadoc/org/apache/kafka/clients/consumer/ConsumerConfig.html"
297-
(get-url '[org.apache.kafka.clients.consumer.ConsumerConfig])))))))
297+
(get-url '[org.apache.kafka.clients.consumer.ConsumerConfig])))))
298+
(testing "Unrecognized java version doesn't blank out the javadocs"
299+
(with-redefs [misc/java-api-version 12345
300+
cache (atom {})]
301+
(is (= "https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/String.html"
302+
(get-url ['java.lang.String])))))))
298303

299304
(deftest class-resolution-test
300305
(let [ns (ns-name *ns*)]

0 commit comments

Comments
 (0)