More stable require of hotloaded dependencies

- make sure we match up the coords we're interested in with the
  correct jar from alembic/resolve-dependencies

- if some namespace in that jar doesn't load correctly, keep going
  with the others (compojure.handler, I'm looking at you)

Author: magnars

src/refactor_nrepl/artifacts.clj

@@ -95,16 +95,20 @@
   "Once the deps are available on cp we still have to load them and
   reset slamhound's cache to make resolve-missing work."
   [coords repos]
-  (try
-    (let [dep (first (alembic/resolve-dependencies alembic/the-still coords repos nil))
-          jarfile (JarFile. (:jar dep))]
-      (dorun (map require (find/find-namespaces-in-jarfile jarfile)))
-      (slamhound/reset))
-    (catch ClassNotFoundException _
-      ;; I've seen this happen after adding core.async as a dependency.
-      ;; A failure here isn't a big deal, it only means that resolve-missing
-      ;; isn't going to work until the namespace has been loaded manually.
-      )))
+  (let [dep (->> (alembic/resolve-dependencies alembic/the-still coords repos nil)
+                 (some (fn [dep] (when (= (:coords dep) (first coords)) dep))))
+        jarfile (JarFile. (:jar dep))]
+    (doseq [namespace (find/find-namespaces-in-jarfile jarfile)]
+      (try
+        (require namespace)
+        (catch Exception _
+          ;; I've seen this happen after adding core.async as a dependency.
+          ;; It also happens if you try to require namespaces that no longer work,
+          ;; like compojure.handler.
+          ;; A failure here isn't a big deal, it only means that resolve-missing
+          ;; isn't going to work until the namespace has been loaded manually.
+          )))
+    (slamhound/reset)))
 
 (defn- ensure-quality-coordinates [coordinates]
   (let [coords (->> coordinates read-string (take 2) vec)]