Fix type bug in DurableObject txn get

vlovich · vlovich · commit 622449ccc355 · 2022-07-11T09:39:05.000-07:00
Transactions are no different from regular operations. get returns
T | undefined
diff --git a/.changeset/rude-apples-bow.md b/.changeset/rude-apples-bow.md
@@ -0,0 +1,5 @@
+---
+"@cloudflare/workers-types": patch
+---
+
+Fix DurableObject transaction `get` to properly return `Promise<T | undefined>` instead of `Promise<T>`
diff --git a/overrides/durableobjects.d.ts b/overrides/durableobjects.d.ts
@@ -50,7 +50,7 @@ declare abstract class DurableObjectStorage {
 }
 
 declare abstract class DurableObjectTransaction {
-  get<T = unknown>(key: string, options?: DurableObjectGetOptions): Promise<T>;
+  get<T = unknown>(key: string, options?: DurableObjectGetOptions): Promise<T | undefined>;
   get<T = unknown>(
     keys: string[],
     options?: DurableObjectGetOptions

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@cloudflare/workers-types": patch
 +---
++
 +Fix DurableObject transaction `get` to properly return `Promise<T | undefined>` instead of `Promise<T>`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ declare abstract class DurableObjectStorage {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`declare abstract class DurableObjectTransaction {`
`53`		`- get<T = unknown>(key: string, options?: DurableObjectGetOptions): Promise<T>;`
	`53`	`+ get<T = unknown>(key: string, options?: DurableObjectGetOptions): Promise<T \| undefined>;`
`54`	`54`	`get<T = unknown>(`
`55`	`55`	`keys: string[],`
`56`	`56`	`options?: DurableObjectGetOptions`