test to validate platform values in index yaml

Author: XenoPhex

repo_index_test.go

@@ -4,6 +4,7 @@ import (
 	"encoding/hex"
 	"io/ioutil"
 	"os"
+	"strings"
 
 	"github.com/cloudfoundry-incubator/cli-plugin-repo/web"
 
@@ -57,6 +58,21 @@ var _ = Describe("Database", func() {
 			}
 		})
 
+		It("validates the platforms for every binary", func() {
+			for _, plugin := range plugins.Plugins {
+				for _, binary := range plugin.Binaries {
+					Expect(web.ValidPlatforms).To(
+						ContainElement(binary.Platform),
+						fmt.Sprintf(
+							"Plunin '%s' contains a platform '%s' that is invalid. Please use one of the following: '%s'",
+							plugin.Name,
+							binary.Platform,
+							strings.Join(web.ValidPlatforms, ", "),
+						))
+				}
+			}
+		})
+
 		It("every binary download had a matching sha1", func() {
 			if os.Getenv("BINARY_VALIDATION") != "true" {
 				Skip("Skipping SHA1 binary checking. To enable, set the BINARY_VALIDATION env variable to 'true'")

web/plugins.go

@@ -2,6 +2,8 @@ package web
 
 import "time"
 
+var ValidPlatforms = []string{"osx", "linux32", "linux64", "win32", "win64"}
+
 type Plugin struct {
 	Name        string    `json:"name"`
 	Description string    `json:"description"`