fix(tunnels): fix encap port validation

aauren · twz123 · aauren · commit 1010e4877b70 · 2024-10-09T15:15:23.000-05:00
Make new logic similar to previous logic and remove superfluous check

Co-authored-by: Tom Wieczorek &lt;twz123@users.noreply.github.com&gt;
diff --git a/pkg/tunnels/linux_tunnels.go b/pkg/tunnels/linux_tunnels.go
@@ -70,7 +70,7 @@ func ParseEncapType(encapType string) (EncapType, error) {
 type EncapPort uint16
 
 func (e EncapPort) checkWithinRange() error {
-	if uint16(e) > minPort && uint16(e) < maxPort {
+	if uint16(e) >= minPort {
 		return nil
 	}
 	return fmt.Errorf("specified encap port is out of range of valid ports: %d, valid range is from %d to %d",

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ func ParseEncapType(encapType string) (EncapType, error) {`
`70`	`70`	`type EncapPort uint16`
`71`	`71`
`72`	`72`	`func (e EncapPort) checkWithinRange() error {`
`73`		`- if uint16(e) > minPort && uint16(e) < maxPort {`
	`73`	`+ if uint16(e) >= minPort {`
`74`	`74`	`return nil`
`75`	`75`	`}`
`76`	`76`	`return fmt.Errorf("specified encap port is out of range of valid ports: %d, valid range is from %d to %d",`