Skip to content

Allow "--override-nexthop" and "tunnel setup cross subnets" to be enabled together #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yydzhou opened this issue Jan 15, 2021 · 3 comments
Labels

Comments

@yydzhou
Copy link
Contributor

yydzhou commented Jan 15, 2021

Is your feature request related to a problem? Please describe.

In current kube-router implementation, enabling of "override-nexthop" will prevent the tunnel from being setup for cross subnet case, regardless of whether the tunnel is enabled or not. In our case, we have multiple group of nodes, and each group of nodes has their own subnets. At same time, each node has multiple upstream routers to peer to support both public and private networking. So both of the override nexthop and tunnel cross different subnet need to work at same time.

Here is the code reference
https://github.com/cloudnativelabs/kube-router/blob/master/pkg/controllers/routing/network_routes_controller.go#L562

Describe the solution you'd like
A clear and concise description of what you want to happen.

The two feature should be controlled independently by user with the provided parameters.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

https://kubernetes.slack.com/archives/C8DCQGTSB/p1610724771001400?thread_ts=1609875847.077500&cid=C8DCQGTSB

@aauren
Copy link
Collaborator

aauren commented Jan 21, 2021

This is related to #749

@yydzhou
Copy link
Contributor Author

yydzhou commented Feb 18, 2021

The required change is merged already. So closing this ticket.

@yydzhou yydzhou closed this as completed Feb 18, 2021
@aauren
Copy link
Collaborator

aauren commented Feb 18, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants