MTN deterministic co_filename for dynamic code pickling #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
==========================================
- Coverage 96.34% 88.71% -7.64%
==========================================
Files 3 3
Lines 575 576 +1
Branches 121 121
==========================================
- Hits 554 511 -43
- Misses 11 51 +40
- Partials 10 14 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ogrisel
reviewed
Mar 27, 2025
Co-authored-by: Olivier Grisel <[email protected]>
|
The failure is deterministic and only happening on windows and on this branch (see #562 running from master and working). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
co_filenameto<dynamic-code>when pickling the code object to make the payload independent of where the code was defined.TODO:
Fix #538