feat: Add package command #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Mar 26, 2024
| @@ -77,6 +78,17 @@ java { | |||
| } | |||
| } | |||
|
|
|||
| jar { | |||
There was a problem hiding this comment.
Used in the Dockerfile to build the MemDB plugin
erezrokah
commented
Mar 26, 2024
| @Setter protected Logger logger; | ||
| @Setter protected String jsonSchema; | ||
|
|
||
| @Setter protected String team; |
There was a problem hiding this comment.
We can't set these to @NonNull as that will force them in the ctor and make it a breaking change
erezrokah
commented
Mar 26, 2024
| @@ -32,7 +31,7 @@ public interface Transform { | |||
| public static List<Table> flattenTables(List<Table> tables) { | |||
| Map<String, Table> flattenMap = new LinkedHashMap<>(); | |||
| for (Table table : tables) { | |||
| Table newTable = table.toBuilder().relations(Collections.emptyList()).build(); | |||
| Table newTable = table.toBuilder().build(); | |||
There was a problem hiding this comment.
Emptying the relations makes it so the tables.json is missing them as we call flattenTables.
Did a check and it seems it not necessary to empty the relations nor it should impact anything else
erezrokah
commented
Mar 26, 2024
| docsDir = Paths.get(pluginDirectory, "docs").toString(); | ||
| } | ||
|
|
||
| initDist(); |
There was a problem hiding this comment.
erezrokah
commented
Mar 26, 2024
| logger.info("Building docker image {}", imageTag); | ||
| // GITHUB_ACTOR and GITHUB_TOKEN are required for the Dockerfile to pull the CloudQuery Java | ||
| // libs from GitHub Packages | ||
| String githubActor = System.getenv("GITHUB_ACTOR"); |
There was a problem hiding this comment.
There's a tricky part with Java since we host the SDK on GitHub packages which requires a token to download libs, so we read it from env variables
hermanschaaf
approved these changes
Mar 26, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.23](v0.0.22...v0.0.23) (2024-03-26) ### Features * Add package command ([#194](#194)) ([05407bb](05407bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cloudquery/cloudquery-issues/issues/790