feat(sync): Send migrate messages #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Aug 21, 2023
| @@ -64,18 +58,7 @@ public void getTables( | |||
| request.getSkipDependentTables()); | |||
| List<ByteString> byteStrings = new ArrayList<>(); | |||
| for (Table table : tables) { | |||
| try (BufferAllocator bufferAllocator = new RootAllocator()) { | |||
There was a problem hiding this comment.
Moved the the Table class under the encode method
erezrokah
commented
Aug 21, 2023
| request.getSkipDependentTables(), | ||
| request.getDeterministicCqId(), | ||
| new BackendOptions( | ||
| request.getBackend().getTableName(), request.getBackend().getConnection()), |
There was a problem hiding this comment.
getBackend() doesn't return null if the backend is not configured
erezrokah
commented
Aug 21, 2023
|
|
||
| @AllArgsConstructor | ||
| @Getter | ||
| public class BackendOptions { |
There was a problem hiding this comment.
Wrapper class so consumers don't need to mess with the gRPC wrapper
erezrokah
commented
Aug 21, 2023
| @@ -88,6 +88,7 @@ private LoggerContext initLogger() { | |||
| context.start(configuration); | |||
|
|
|||
| logger = context.getLogger(ServeCommand.class.getName()); | |||
| this.plugin.setLogger(logger); | |||
There was a problem hiding this comment.
Setting the logger on the plugin was missing
erezrokah
commented
Aug 21, 2023
| @@ -228,4 +236,19 @@ public Schema toArrowSchema() { | |||
| Schema schema = new Schema(asList(fields), metadata); | |||
| return schema; | |||
| } | |||
|
|
|||
| public ByteString encode() throws IOException { | |||
| try (BufferAllocator bufferAllocator = new RootAllocator()) { | |||
There was a problem hiding this comment.
Moved from PluginServer.java
mnorbury
approved these changes
Aug 21, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
🤖 I have created a release *beep* *boop* --- ## 0.0.1 (2023-08-24) ### Features * `io.cloudquery.scalar.Binary` implementation ([#20](#20)) ([b9b73d1](b9b73d1)) * `io.cloudquery.scalar.Bool` ([#27](#27)) ([2a91c92](2a91c92)), closes [#26](#26) * adding basic support for tables ([#19](#19)) ([22b2350](22b2350)) * adding JSON scalar ([#82](#82)) ([fc92542](fc92542)), closes [#63](#63) * adding Table filterDFS functionaility ([#21](#21)) ([02d8515](02d8515)) * Date scalars ([#36](#36)) ([adc6ba2](adc6ba2)), closes [#34](#34) * Duration scalar ([#42](#42)) ([7529438](7529438)), closes [#39](#39) * Encode resources with data ([#88](#88)) ([2c7060f](2c7060f)) * Generics in scalars ([#56](#56)) ([bc7d6e3](bc7d6e3)) * Implement `getTables` ([#71](#71)) ([085c51f](085c51f)) * Implement concurrency and relations resolving ([#91](#91)) ([0a470b7](0a470b7)) * Init logger, add initial MemDB plugin ([#70](#70)) ([20ebb42](20ebb42)) * int/uint/float/string scalars ([#59](#59)) ([39ec6e6](39ec6e6)), closes [#53](#53) [#54](#54) [#58](#58) [#60](#60) * Resolve CQId, add CQIds to MemDB plugin ([#95](#95)) ([9d7f1bd](9d7f1bd)) * Scalar Timestamp ([#46](#46)) ([4220e92](4220e92)), closes [#44](#44) * **sync:** Initial insert message support ([#81](#81)) ([bd729bb](bd729bb)) * **sync:** Send migrate messages ([#79](#79)) ([dd2c1a5](dd2c1a5)) ### Bug Fixes * Add `jackson-annotations` to `build.gradle` ([#83](#83)) ([ead7dd9](ead7dd9)) * **deps:** Update dependency com.google.guava:guava to v32 ([#15](#15)) ([ce8028b](ce8028b)) * **deps:** Update dependency io.grpc:grpc-protobuf to v1.57.1 ([#10](#10)) ([bcfa29c](bcfa29c)) * **deps:** Update dependency io.grpc:grpc-services to v1.57.1 ([#11](#11)) ([71c2ea1](71c2ea1)) * **deps:** Update dependency io.grpc:grpc-stub to v1.57.1 ([#12](#12)) ([c65e5d6](c65e5d6)) * **deps:** Update dependency io.grpc:grpc-testing to v1.57.1 ([#13](#13)) ([a7b1fa6](a7b1fa6)) * **deps:** Update plugin org.gradle.toolchains.foojay-resolver-convention to v0.6.0 ([#14](#14)) ([443990c](443990c)) * Flatten tables in getTables gRPC call ([#80](#80)) ([8c9872a](8c9872a)) * Pass options to tables method ([#78](#78)) ([4b77a2f](4b77a2f)) ### Miscellaneous Chores * Release 0.0.1 ([e169dbc](e169dbc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of the sync, sending migrate table messages to the client