Skip to content

fix: Fix exception logging #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2023
Merged

fix: Fix exception logging #18

merged 2 commits into from
Aug 1, 2023

Conversation

hermanschaaf
Copy link
Member

@hermanschaaf hermanschaaf commented Aug 1, 2023

It's exc_info not exec_info, and exc_info just needs to evaluate to True. It takes the exception from the context.

@hermanschaaf hermanschaaf added the automerge Add to automerge PRs once requirements are met label Aug 1, 2023
@kodiakhq kodiakhq bot merged commit 2a5996b into main Aug 1, 2023
@kodiakhq kodiakhq bot deleted the exception-logging branch August 1, 2023 14:48
@cq-bot cq-bot mentioned this pull request Aug 1, 2023
kodiakhq bot pushed a commit that referenced this pull request Aug 2, 2023
🤖 I have created a release *beep* *boop*
---


## [0.0.9](v0.0.8...v0.0.9) (2023-08-02)


### Features

* Add override_columns to openapi transformer ([#22](#22)) ([a53bb0e](a53bb0e))
* Wire logging with cli flags ([#26](#26)) ([106781b](106781b))


### Bug Fixes

* Add better logging for scheduler ([#24](#24)) ([505f94b](505f94b))
* Add more command-line args, use standard logging ([#29](#29)) ([5d52af9](5d52af9))
* Emit migrate messages for child relations ([#21](#21)) ([536e163](536e163))
* Fix column resolver resource set ([#23](#23)) ([9936ced](9936ced))
* Fix exception logging ([#18](#18)) ([2a5996b](2a5996b))
* Fix extension type definitions ([#20](#20)) ([146c549](146c549))
* Fix JSON type handling ([#19](#19)) ([c0cdf55](c0cdf55))
* Fix race in scheduler ([#25](#25)) ([17fee27](17fee27))
* Log error on table resolver exception/error ([#16](#16)) ([a1b07e8](a1b07e8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to automerge PRs once requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants