Skip to content

Commit 65e9f1a

Browse files
authored
fix(plugin-tables): Add missing skip_dependent_tables (#1136)
#### Summary <!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> Goes with cloudquery/plugin-pb#17 and cloudquery/plugin-pb-go#84 --- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑‍🎓 - [ ] Run `go fmt` to format your code 🖊 - [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Update or add tests 🧪 - [ ] Ensure the status checks below are successful ✅
1 parent ed96059 commit 65e9f1a

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ go 1.19
55
require (
66
github.com/apache/arrow/go/v13 v13.0.0-20230731205701-112f94971882
77
github.com/bradleyjkemp/cupaloy/v2 v2.8.0
8-
github.com/cloudquery/plugin-pb-go v1.9.1
8+
github.com/cloudquery/plugin-pb-go v1.9.2
99
github.com/cloudquery/plugin-sdk/v2 v2.7.0
1010
github.com/getsentry/sentry-go v0.20.0
1111
github.com/goccy/go-json v0.10.2
@@ -37,7 +37,7 @@ require (
3737
github.com/go-logr/logr v1.2.4 // indirect
3838
github.com/go-logr/stdr v1.2.2 // indirect
3939
github.com/golang/protobuf v1.5.3 // indirect
40-
github.com/google/flatbuffers v23.1.21+incompatible // indirect
40+
github.com/google/flatbuffers v23.5.26+incompatible // indirect
4141
github.com/grpc-ecosystem/grpc-gateway/v2 v2.7.0 // indirect
4242
github.com/inconshreveable/mousetrap v1.1.0 // indirect
4343
github.com/klauspost/compress v1.16.7 // indirect

go.sum

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMn
4848
github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
4949
github.com/cloudquery/arrow/go/v13 v13.0.0-20230805001301-f53878dc8a89 h1:8AahfL6H9XYnz8DgCYeb9ed7sviEObA+nGdsdUIyerM=
5050
github.com/cloudquery/arrow/go/v13 v13.0.0-20230805001301-f53878dc8a89/go.mod h1:W69eByFNO0ZR30q1/7Sr9d83zcVZmF2MiP3fFYAWJOc=
51-
github.com/cloudquery/plugin-pb-go v1.9.1 h1:XCV063uKXPYFnD8JUft8bxbFL60UHjkQKgh6Zp7xAuU=
52-
github.com/cloudquery/plugin-pb-go v1.9.1/go.mod h1:XN3rZ4pptgjDKAGiVNUCNRZnAWACE0p0O9DFa8TfEA8=
51+
github.com/cloudquery/plugin-pb-go v1.9.2 h1:jApELKSgtyj1dKQlD2hKPMTFs1GqOdSK8u+5rEluj4M=
52+
github.com/cloudquery/plugin-pb-go v1.9.2/go.mod h1:f00zd6V5mWD+8Qw9U0eb4HD8RnAobwV9byBexE7Qa+0=
5353
github.com/cloudquery/plugin-sdk/v2 v2.7.0 h1:hRXsdEiaOxJtsn/wZMFQC9/jPfU1MeMK3KF+gPGqm7U=
5454
github.com/cloudquery/plugin-sdk/v2 v2.7.0/go.mod h1:pAX6ojIW99b/Vg4CkhnsGkRIzNaVEceYMR+Bdit73ug=
5555
github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
@@ -124,8 +124,8 @@ github.com/golang/protobuf v1.5.3 h1:KhyjKVUg7Usr/dYsdSqoFveMYd5ko72D+zANwlG1mmg
124124
github.com/golang/protobuf v1.5.3/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY=
125125
github.com/google/btree v0.0.0-20180813153112-4030bb1f1f0c/go.mod h1:lNA+9X1NB3Zf8V7Ke586lFgjr2dZNuvo3lPJSGZ5JPQ=
126126
github.com/google/btree v1.0.0/go.mod h1:lNA+9X1NB3Zf8V7Ke586lFgjr2dZNuvo3lPJSGZ5JPQ=
127-
github.com/google/flatbuffers v23.1.21+incompatible h1:bUqzx/MXCDxuS0hRJL2EfjyZL3uQrPbMocUa8zGqsTA=
128-
github.com/google/flatbuffers v23.1.21+incompatible/go.mod h1:1AeVuKshWv4vARoZatz6mlQ0JxURH0Kv5+zNeJKJCa8=
127+
github.com/google/flatbuffers v23.5.26+incompatible h1:M9dgRyhJemaM4Sw8+66GHBu8ioaQmyPLg1b8VwK5WJg=
128+
github.com/google/flatbuffers v23.5.26+incompatible/go.mod h1:1AeVuKshWv4vARoZatz6mlQ0JxURH0Kv5+zNeJKJCa8=
129129
github.com/google/go-cmp v0.2.0/go.mod h1:oXzfMopK8JAjlY9xF4vHSVASa0yLyX7SntLO5aqRK0M=
130130
github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
131131
github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=

internal/servers/plugin/v3/plugin.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,9 @@ type Server struct {
2929

3030
func (s *Server) GetTables(ctx context.Context, req *pb.GetTables_Request) (*pb.GetTables_Response, error) {
3131
tables, err := s.Plugin.Tables(ctx, plugin.TableOptions{
32-
Tables: req.Tables,
33-
SkipTables: req.SkipTables,
32+
Tables: req.Tables,
33+
SkipTables: req.SkipTables,
34+
SkipDependentTables: req.SkipDependentTables,
3435
})
3536
if err != nil {
3637
return nil, status.Errorf(codes.Internal, "failed to get tables: %v", err)

0 commit comments

Comments
 (0)