Skip to content

Commit 5c35c4e

Browse files
authored
Merge pull request #18 from SimonFrings/tests
Run tests on PHPUnit 9 and update PHPUnit configuration schema for PHPUnit 9.3
2 parents 7a6f5f9 + f828a0c commit 5c35c4e

9 files changed

+54
-16
lines changed

.gitattributes

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,5 @@
33
/.travis.yml export-ignore
44
/examples/ export-ignore
55
/phpunit.xml.dist export-ignore
6+
/phpunit.xml.legacy export-ignore
67
/tests/ export-ignore

.travis.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ language: php
33
# lock distro so new future defaults will not break the build
44
dist: trusty
55

6-
matrix:
6+
jobs:
77
include:
88
- php: 5.3
99
dist: precise
@@ -21,10 +21,9 @@ matrix:
2121
allow_failures:
2222
- php: hhvm-3.18
2323

24-
sudo: false
25-
2624
install:
27-
- composer install --no-interaction
25+
- composer install
2826

2927
script:
30-
- vendor/bin/phpunit --coverage-text
28+
- if [[ "$TRAVIS_PHP_VERSION" > "7.2" ]]; then vendor/bin/phpunit --coverage-text; fi
29+
- if [[ "$TRAVIS_PHP_VERSION" < "7.3" ]]; then vendor/bin/phpunit --coverage-text -c phpunit.xml.legacy; fi

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"react/stream": "^1.0 || ^0.7 || ^0.6"
2222
},
2323
"require-dev": {
24-
"phpunit/phpunit": "^7.0 || ^6.0 || ^5.7 || ^4.8.35",
24+
"phpunit/phpunit": "^9.3 || ^5.7 || ^4.8.35",
2525
"react/child-process": "^0.6",
2626
"react/event-loop": "^1.0 || ^0.5 || ^0.4 || ^0.3"
2727
}

phpunit.xml.dist

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,19 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22

3-
<phpunit bootstrap="vendor/autoload.php" colors="true">
3+
<!-- PHPUnit configuration file with new format for PHPUnit 9.3+ -->
4+
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
6+
bootstrap="vendor/autoload.php"
7+
colors="true"
8+
cacheResult="false">
49
<testsuites>
5-
<testsuite name="CSV test suite">
10+
<testsuite name="CSV Test Suite">
611
<directory>./tests/</directory>
712
</testsuite>
813
</testsuites>
9-
<filter>
10-
<whitelist>
14+
<coverage>
15+
<include>
1116
<directory>./src/</directory>
12-
</whitelist>
13-
</filter>
17+
</include>
18+
</coverage>
1419
</phpunit>

phpunit.xml.legacy

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
3+
<!-- PHPUnit configuration file with old format for PHPUnit 9.2 or older -->
4+
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/4.8/phpunit.xsd"
6+
bootstrap="vendor/autoload.php"
7+
colors="true">
8+
<testsuites>
9+
<testsuite name="CSV Test Suite">
10+
<directory>./tests/</directory>
11+
</testsuite>
12+
</testsuites>
13+
<filter>
14+
<whitelist>
15+
<directory>./src/</directory>
16+
</whitelist>
17+
</filter>
18+
</phpunit>

tests/AssocDecoderTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ class AssocDecoderTest extends TestCase
1010
private $input;
1111
private $decoder;
1212

13-
public function setUp()
13+
/**
14+
* @before
15+
*/
16+
public function setUpDecoder()
1417
{
1518
$stream = fopen('php://temp', 'r');
1619
$loop = $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();

tests/DecoderTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ class DecoderTest extends TestCase
1010
private $input;
1111
private $decoder;
1212

13-
public function setUp()
13+
/**
14+
* @before
15+
*/
16+
public function setUpDecoder()
1417
{
1518
$stream = fopen('php://temp', 'r');
1619
$loop = $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();

tests/EncoderTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ class EncoderTest extends TestCase
1010
private $output;
1111
private $encoder;
1212

13-
public function setUp()
13+
/**
14+
* @before
15+
*/
16+
public function setUpEncoder()
1417
{
1518
$stream = fopen('php://temp', 'r+');
1619
$loop = $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();

tests/TestCase.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,12 @@ protected function expectCallableOnceWith($value)
3939

4040
protected function createCallableMock()
4141
{
42-
return $this->getMockBuilder('stdClass')->setMethods(array('__invoke'))->getMock();
42+
if (method_exists('PHPUnit\Framework\MockObject\MockBuilder', 'addMethods')) {
43+
// PHPUnit 9+
44+
return $this->getMockBuilder('stdClass')->addMethods(array('__invoke'))->getMock();
45+
} else {
46+
// legacy PHPUnit 4 - PHPUnit 8
47+
return $this->getMockBuilder('stdClass')->setMethods(array('__invoke'))->getMock();
48+
}
4349
}
4450
}

0 commit comments

Comments
 (0)