pythongh-129205: Use os.readinto() in subprocess errpipe_read

Read into a pre-allocated fixed size buffer.

The previous code the buffer could actually get to 100_000 bytes in two
reads (first read returns 50_000, second pass through loop gets another
50_000), so this does change behavior. I think the fixed length of
50_000 was the intention though. This is used to pass exception issues
that happen during _fork_exec from the child to parent process.

Author: cmaloney

Lib/subprocess.py

@@ -1921,12 +1921,13 @@ def _execute_child(self, args, executable, preexec_fn, close_fds,
 
                 # Wait for exec to fail or succeed; possibly raising an
                 # exception (limited in size)
-                errpipe_data = bytearray()
-                while True:
-                    part = os.read(errpipe_read, 50000)
-                    errpipe_data += part
-                    if not part or len(errpipe_data) > 50000:
-                        break
+                errpipe_data = bytearray(50000)
+                unread = memoryview(errpipe_data)
+                while count := os.readinto(errpipe_read, unread):
+                    unread = unread[count:]
+                bytes_left = len(unread)
+                del unread
+                del errpipe_data[-bytes_left:]
             finally:
                 # be sure the FD is closed no matter what
                 os.close(errpipe_read)