Skip to content

Commit 4cb88f4

Browse files
committed
feat: use delphi-logger
* update requirements files to use git repo * import logger from delphi-logger package instead of relative * remove duplicate logger.py in this repo * update delphi-epidata.py client to only depend on logger
1 parent 69835d1 commit 4cb88f4

22 files changed

+726
-284
lines changed

requirements.api.txt

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
delphi_utils
2+
delphi_logger @ git+https://github.com/cmu-delphi/delphi-logger
23
epiweeks==2.1.2
34
Flask==2.2.5
45
Flask-Limiter==3.3.0

requirements.dev.txt

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ black>=20.8b1
33
bump2version==1.0.1
44
covidcast==0.1.5
55
delphi_utils
6+
delphi_logger @ git+https://github.com/cmu-delphi/delphi-logger
67
docker==6.0.1
78
dropbox==11.36.0
89
freezegun==1.2.2

src/acquisition/covid_hosp/common/database.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
# first party
1313
import delphi.operations.secrets as secrets
14-
from delphi.epidata.common.logger import get_structured_logger
14+
from delphi_logger import get_structured_logger
1515

1616
Columndef = namedtuple("Columndef", "csv_name sql_name dtype")
1717

src/acquisition/covidcast/csv_importer.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from delphi_utils import Nans
1717
from delphi.utils.epiweek import delta_epiweeks
1818
from delphi.epidata.common.covidcast_row import CovidcastRow
19-
from delphi.epidata.common.logger import get_structured_logger
19+
from delphi_logger import get_structured_logger
2020

2121
DataFrameRow = NamedTuple('DFRow', [
2222
('geo_id', str),

src/acquisition/covidcast/csv_to_database.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from delphi.epidata.acquisition.covidcast.csv_importer import CsvImporter, PathDetails
1212
from delphi.epidata.acquisition.covidcast.database import Database, DBLoadStateException
1313
from delphi.epidata.acquisition.covidcast.file_archiver import FileArchiver
14-
from delphi.epidata.common.logger import get_structured_logger
14+
from delphi_logger import get_structured_logger
1515

1616

1717
def get_argument_parser():

src/acquisition/covidcast/database.py

+10-10
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
# first party
1616
import delphi.operations.secrets as secrets
17-
from delphi.epidata.common.logger import get_structured_logger
17+
from delphi_logger import get_structured_logger
1818
from delphi.epidata.common.covidcast_row import CovidcastRow
1919

2020

@@ -117,28 +117,28 @@ def insert_or_update_batch(self, cc_rows: List[CovidcastRow], batch_size=2**20,
117117
get_structured_logger("insert_or_update_batch").fatal(err_msg)
118118
raise DBLoadStateException(err_msg)
119119

120-
# NOTE: `value_update_timestamp` is hardcoded to "NOW" (which is appropriate) and
120+
# NOTE: `value_update_timestamp` is hardcoded to "NOW" (which is appropriate) and
121121
# `is_latest_issue` is hardcoded to 1 (which is temporary and addressed later in this method)
122122
insert_into_loader_sql = f'''
123123
INSERT INTO `{self.load_table}`
124124
(`source`, `signal`, `time_type`, `geo_type`, `time_value`, `geo_value`,
125-
`value_updated_timestamp`, `value`, `stderr`, `sample_size`, `issue`, `lag`,
125+
`value_updated_timestamp`, `value`, `stderr`, `sample_size`, `issue`, `lag`,
126126
`is_latest_issue`, `missing_value`, `missing_stderr`, `missing_sample_size`)
127127
VALUES
128-
(%s, %s, %s, %s, %s, %s,
129-
UNIX_TIMESTAMP(NOW()), %s, %s, %s, %s, %s,
128+
(%s, %s, %s, %s, %s, %s,
129+
UNIX_TIMESTAMP(NOW()), %s, %s, %s, %s, %s,
130130
1, %s, %s, %s)
131131
'''
132132

133133
# all load table entries are already marked "is_latest_issue".
134134
# if an entry in the load table is NOT in the latest table, it is clearly now the latest value for that key (so we do nothing (thanks to INNER join)).
135135
# if an entry *IS* in both load and latest tables, but latest table issue is newer, unmark is_latest_issue in load.
136136
fix_is_latest_issue_sql = f'''
137-
UPDATE
138-
`{self.load_table}` JOIN `{self.latest_view}`
139-
USING (`source`, `signal`, `geo_type`, `geo_value`, `time_type`, `time_value`)
140-
SET `{self.load_table}`.`is_latest_issue`=0
141-
WHERE `{self.load_table}`.`issue` < `{self.latest_view}`.`issue`
137+
UPDATE
138+
`{self.load_table}` JOIN `{self.latest_view}`
139+
USING (`source`, `signal`, `geo_type`, `geo_value`, `time_type`, `time_value`)
140+
SET `{self.load_table}`.`is_latest_issue`=0
141+
WHERE `{self.load_table}`.`issue` < `{self.latest_view}`.`issue`
142142
'''
143143

144144
# TODO: consider handling cc_rows as a generator instead of a list

src/acquisition/covidcast/file_archiver.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import shutil
77

88
# first party
9-
from delphi.epidata.common.logger import get_structured_logger
9+
from delphi_logger import get_structured_logger
1010

1111
class FileArchiver:
1212
"""Archives files by moving and compressing."""

src/client/delphi_epidata.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
from aiohttp import ClientSession, TCPConnector, BasicAuth
1818

19-
from delphi_utils.logger import get_structured_logger
19+
from delphi_logger import get_structured_logger
2020

2121
__version__ = "4.1.23"
2222

0 commit comments

Comments
 (0)