-
Notifications
You must be signed in to change notification settings - Fork 68
Alphabetize reordered data source menu #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmdefries, as of Thurs Feb 13 morning I ran this branch using the Jekyll build and it appears:
-
for the Covidcast data sources and signals menu the alphabetization down the list looks fine until you reach the inactive signals, and
-
for the Other Endpoints data sources and signals menu both active and inactive signals are alphabetized correctly except for:
_inactive_ Epidata Metadata _inactive_ CDC _inactive_ COVID-19 reported patient impact and hospital capacity by state timeseries
|
Summary:
Context
When using the
nav_order
setting in markdown front matter, pages sharing the samenav_order
are alphabetized by filename, NOT by title. For existing pages, change filenames to alphabetize properly but specifypermalink
to keep URLs the same.(For new pages, filenames should be set to match page titles so that alphabetization is correct. Adding permalinks is unnecessary.
We could also force alphabetization using
nav_order
, but this approach minimizes future work. That is, we won't have to keep inserting newnav_order
values between existing ones. All new inactive data sources will be assignednav_order: 2
; active ones will havenav_order: 1
.)Also mention "NHSN" in hhs documentation.
Prerequisites:
dev
branchdev