Skip to content

Alphabetize reordered data source menu #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 20, 2025
Merged

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Sep 3, 2024

Summary:

Context

When using the nav_order setting in markdown front matter, pages sharing the same nav_order are alphabetized by filename, NOT by title. For existing pages, change filenames to alphabetize properly but specify permalink to keep URLs the same.

(For new pages, filenames should be set to match page titles so that alphabetization is correct. Adding permalinks is unnecessary.

We could also force alphabetization using nav_order, but this approach minimizes future work. That is, we won't have to keep inserting new nav_order values between existing ones. All new inactive data sources will be assigned nav_order: 2; active ones will have nav_order: 1.)

Also mention "NHSN" in hhs documentation.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Copy link

sonarqubecloud bot commented Sep 3, 2024

@nmdefries nmdefries requested a review from tinatownes September 3, 2024 21:54
Base automatically changed from ndefries/menu-cleanup to dev September 9, 2024 19:18
Copy link
Collaborator

@tinatownes tinatownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmdefries, as of Thurs Feb 13 morning I ran this branch using the Jekyll build and it appears:

  • for the Covidcast data sources and signals menu the alphabetization down the list looks fine until you reach the inactive signals, and

  • for the Other Endpoints data sources and signals menu both active and inactive signals are alphabetized correctly except for:

            _inactive_ Epidata Metadata
            _inactive_ CDC 
            _inactive_ COVID-19 reported patient impact and hospital capacity by state timeseries
    

@nmdefries
Copy link
Contributor Author

nmdefries commented Feb 13, 2025

I think I'd intended the Epidata Metadata page to be listed first (specifically because it's metadata). The CDC and COVID... pages look like they're in the right order to me.
Screenshot from 2025-02-13 13-21-17

Covidcast inactive pages also are alphabetical for me. Hopefully not a dependency/version issue! Could you send a screenshot of what you're seeing?

@tinatownes
Copy link
Collaborator

Ah ok, I understand the Epidata Metadata page organization. With this in mind, I agree with you, the order looks good for other endpoints!

Here's what I see in the Covidcast inactive menu. It's inactive SafeGraph, inactive USAFacts, then inactive Indicator Combination, etc. :

Screenshot 2025-02-13 at 1 46 58 PM

@nmdefries nmdefries merged commit 204a714 into dev Feb 20, 2025
8 checks passed
@nmdefries nmdefries deleted the ndefries/menu-alphabetize branch February 20, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants