Skip to content

Commit 547e3b0

Browse files
authored
Fix undefined behavior in movemask_epi8 (rust-lang#1354)
Fixes rust-lang/stdarch#1347
1 parent 88bef95 commit 547e3b0

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

crates/core_arch/src/x86/avx2.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -2001,7 +2001,9 @@ pub unsafe fn _mm256_min_epu8(a: __m256i, b: __m256i) -> __m256i {
20012001
#[cfg_attr(test, assert_instr(vpmovmskb))]
20022002
#[stable(feature = "simd_x86", since = "1.27.0")]
20032003
pub unsafe fn _mm256_movemask_epi8(a: __m256i) -> i32 {
2004-
simd_bitmask::<_, u32>(a.as_i8x32()) as i32
2004+
let z = i8x32::splat(0);
2005+
let m: i8x32 = simd_lt(a.as_i8x32(), z);
2006+
simd_bitmask::<_, u32>(m) as i32
20052007
}
20062008

20072009
/// Computes the sum of absolute differences (SADs) of quadruplets of unsigned

crates/core_arch/src/x86/sse2.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -1378,7 +1378,9 @@ pub unsafe fn _mm_insert_epi16<const IMM8: i32>(a: __m128i, i: i32) -> __m128i {
13781378
#[cfg_attr(test, assert_instr(pmovmskb))]
13791379
#[stable(feature = "simd_x86", since = "1.27.0")]
13801380
pub unsafe fn _mm_movemask_epi8(a: __m128i) -> i32 {
1381-
simd_bitmask::<_, u16>(a.as_i8x16()) as u32 as i32
1381+
let z = i8x16::splat(0);
1382+
let m: i8x16 = simd_lt(a.as_i8x16(), z);
1383+
simd_bitmask::<_, u16>(m) as u32 as i32
13821384
}
13831385

13841386
/// Shuffles 32-bit integers in `a` using the control in `IMM8`.

0 commit comments

Comments
 (0)