WIP on buffer size validation against raft command size

yuzefovich · yuzefovich · commit d90fbd77557d · 2025-04-04T18:59:18.000-07:00
diff --git a/pkg/kv/kvserver/kvserverbase/base.go b/pkg/kv/kvserver/kvserverbase/base.go
@@ -310,6 +310,8 @@ const (
 )
 
 // MaxCommandSize wraps "kv.raft.command.max_size".
+// TODO: maybe add validation on the buffer size that it's below raft command
+// size and in reverse?
 var MaxCommandSize = settings.RegisterByteSizeSetting(
 	settings.SystemVisible, // used by SQL/bulk to determine mutation batch sizes
 	"kv.raft.command.max_size",

Original file line number	Diff line number	Diff line change
`@@ -310,6 +310,8 @@ const (`
`310`	`310`	`)`
`311`	`311`
`312`	`312`	`// MaxCommandSize wraps "kv.raft.command.max_size".`
	`313`	`+// TODO: maybe add validation on the buffer size that it's below raft command`
	`314`	`+// size and in reverse?`
`313`	`315`	`var MaxCommandSize = settings.RegisterByteSizeSetting(`
`314`	`316`	`settings.SystemVisible, // used by SQL/bulk to determine mutation batch sizes`
`315`	`317`	`"kv.raft.command.max_size",`