Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: test kvprober including crdb_internal.probe_ranges #102034

Open
nicktrav opened this issue Apr 21, 2023 · 1 comment · May be fixed by #143901 or #143902
Open

roachtest: test kvprober including crdb_internal.probe_ranges #102034

nicktrav opened this issue Apr 21, 2023 · 1 comment · May be fixed by #143901 or #143902
Assignees
@noahstho
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. P-2 Issues/test failures with a fix SLA of 3 months quality-friday A good issue to work on on Quality Friday T-sre

Comments

@nicktrav
Copy link
Collaborator

nicktrav commented Apr 21, 2023 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.

We have a number of internal commands / tools that are commonly used in day-to-day cluster operations / management.

Ideally, we'd test that these tools work as expected, and do not have a negative impact on a cluster, after some duration.

Add a roachtest that covers these operational commands.

Jira issue: CRDB-27230
@nicktrav nicktrav added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. T-sre labels Apr 21, 2023
@nicktrav
Copy link
Collaborator Author

cc: @joshimhoff

@erikgrinaker erikgrinaker added the quality-friday A good issue to work on on Quality Friday label Jul 20, 2023
@exalate-issue-sync exalate-issue-sync bot added T-sre O-postmortem Originated from a Postmortem action item. and removed O-postmortem Originated from a Postmortem action item. T-sre labels Oct 4, 2023
@exalate-issue-sync exalate-issue-sync bot changed the title roachtest: test internal builtins that are commonly used for cluster operations roachtest: test kvprober including crdb_internal.probe_ranges Oct 5, 2023
@Schtick Schtick closed this as completed Oct 5, 2023
@Schtick Schtick reopened this Oct 5, 2023
@lunevalex lunevalex added the P-3 Issues/test failures with no fix SLA label Apr 25, 2024
@exalate-issue-sync exalate-issue-sync bot added P-2 Issues/test failures with a fix SLA of 3 months and removed P-3 Issues/test failures with no fix SLA labels Nov 12, 2024
@exalate-issue-sync exalate-issue-sync bot assigned noahstho and unassigned joshimhoff Feb 19, 2025
noahstho added a commit to noahstho/cockroachfork that referenced this issue Mar 25, 2025
@noahstho
roachtest: Add mixed version kvprober test
900459b 
Since the kv prober is an important tool, we would like to
add some additional tests to ensure that it continues to work.
This is a simple nightly roach test that ensures we can query
crdb_internal.probe_ranges and it successfully returns with no
errors. This PR should be followed by testing the kv_prober_enabled
cluster setting.

resolves: cockroachdb#102034
Epic: none
Release note: none
@noahstho noahstho mentioned this issue Mar 25, 2025
Closed
noahstho added a commit to noahstho/cockroachfork that referenced this issue Mar 31, 2025
@noahstho
roachtest: Add mixed version kvprober test
058994e 
Since the kv prober is used for critical alerts, we would like to
add some additional tests to ensure that it continues to work.
This is a simple nightly roach test that ensures we can query
crdb_internal.probe_ranges and it successfully returns with no
errors.

resolves: cockroachdb#102034
Epic: none
Release note: none
noahstho added a commit to noahstho/cockroachfork that referenced this issue Mar 31, 2025
@noahstho
roachtest: Add mixed version kvprober test
00df163 
Since the kv prober is used for critical alerts, we would like to
add some additional tests to ensure that it continues to work.
This is a simple nightly roach test that ensures we can query
crdb_internal.probe_ranges and it successfully returns with no
errors.

resolves: cockroachdb#102034
Epic: none
Release note: none
@noahstho noahstho mentioned this issue Mar 31, 2025
Closed
noahstho added a commit to noahstho/cockroachfork that referenced this issue Mar 31, 2025
@noahstho
roachtest: Add mixed version kvprober test
a0a3fd1 
Since the kv prober is used for critical alerts, we would like to
add some additional tests to ensure that it continues to work.
This is a simple nightly roach test that ensures we can query
crdb_internal.probe_ranges and it successfully returns with no
errors.

resolves: cockroachdb#102034
Epic: none
Release note: none
noahstho added a commit to noahstho/cockroachfork that referenced this issue Apr 1, 2025
@noahstho
roachtest: Add mixed version kvprober test
fa38c27 
Since the kv prober is used for critical alerts, we would like to
add some additional tests to ensure that it continues to work.
This is a simple nightly roach test that ensures we can query
crdb_internal.probe_ranges and it successfully returns with no
errors.

resolves: cockroachdb#102034
Epic: none
Release note: none
noahstho added a commit to noahstho/cockroachfork that referenced this issue Apr 3, 2025
@noahstho
roachtest: add operation to toggle kv prober setting on drt clusters
36ed0a3 
Currently, kv prober is not tested in long-lived testing clusters.
We would like to improve quality of coverage for kv prober due to
incident.

resolves: cockroachdb#102034
Release note: None
Epic: None
@noahstho noahstho linked a pull request Apr 3, 2025 that will close this issue
Draft
noahstho added a commit to noahstho/cockroachfork that referenced this issue Apr 3, 2025
@noahstho
roachtest: add operation to query crdb_internal.probe_ranges
318c239 
Since SRE uses crdb_internal.probe_ranges to test for prod
cluster health, we would like to add this as a roach operation
to make the DRT cluster as realistic as possible, and test for
potential issues with crdb_internal.probe_ranges.

Fixes: cockroachdb#102034
Release note: None
Epic: None
@noahstho noahstho linked a pull request Apr 3, 2025 that will close this issue
Draft
noahstho added a commit to noahstho/cockroachfork that referenced this issue Apr 3, 2025
@noahstho
roachtest: add operation to query crdb_internal.probe_ranges
cb471bf 
Since SRE uses crdb_internal.probe_ranges to test for prod
cluster health, we would like to add this as a roach operation
to make the DRT cluster as realistic as possible, and test for
potential issues with crdb_internal.probe_ranges.

Fixes: cockroachdb#102034
Release note: None
Epic: None
noahstho added a commit to noahstho/cockroachfork that referenced this issue Apr 3, 2025
@noahstho
roachtest: add operation to toggle kv prober setting on drt clusters
24a6d03 
Currently, kv prober is not tested in long-lived testing clusters.
We would like to improve quality of coverage for kv prober due to
incident.

resolves: cockroachdb#102034
Release note: None
Epic: None
noahstho added a commit to noahstho/cockroachfork that referenced this issue Apr 3, 2025
@noahstho
roachtest: add operation to toggle kv prober setting on drt clusters
52ef77a 
Currently, kv prober is not tested in long-lived testing clusters.
We would like to improve quality of coverage for kv prober due to
incident.

resolves: cockroachdb#102034
Release note: None
Epic: None
noahstho added a commit to noahstho/cockroachfork that referenced this issue Apr 3, 2025
@noahstho
roachtest: add operation to query crdb_internal.probe_ranges
7751a2c 
Since SRE uses crdb_internal.probe_ranges to test for prod
cluster health, we would like to add this as a roach operation
to make the DRT cluster as realistic as possible, and test for
potential issues with crdb_internal.probe_ranges.

Fixes: cockroachdb#102034
Release note: None
Epic: None
noahstho added a commit to noahstho/cockroachfork that referenced this issue Apr 4, 2025
@noahstho
roachtest: add operation to query crdb_internal.probe_ranges
b861045 
Since SRE uses crdb_internal.probe_ranges to test for prod
cluster health, we would like to add this as a roach operation
to make the DRT cluster as realistic as possible, and test for
potential issues with crdb_internal.probe_ranges.

Fixes: cockroachdb#102034
Release note: None
Epic: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahstho noahstho

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. P-2 Issues/test failures with a fix SLA of 3 months quality-friday A good issue to work on on Quality Friday T-sre
Projects
None yet
Milestone
No milestone
6 participants
@erikgrinaker @nicktrav @joshimhoff @Schtick @lunevalex @noahstho