Skip to content

sql/row: TestRowFetcherMVCCMetadata failed #147174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cockroach-teamcity opened this issue May 22, 2025 · 1 comment · Fixed by #147182
Closed

sql/row: TestRowFetcherMVCCMetadata failed #147174

cockroach-teamcity opened this issue May 22, 2025 · 1 comment · Fixed by #147182
Assignees
@yuzefovich
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team target-release-25.3.0

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 22, 2025 •
edited by cockroach-jira-scripts
Loading

sql/row.TestRowFetcherMVCCMetadata failed with artifacts on master @ f92b30e3626c9f32191555da8d929eddc59ca956:

=== RUN   TestRowFetcherMVCCMetadata
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/9db56821b86748e0fc537f3d515778f0/logTestRowFetcherMVCCMetadata177548470
    test_log_scope.go:76: use -show-logs to present logs inline
    fetcher_mvcc_test.go:157: expected [{[1 a a a] false 1747937531343998314.0000000000} {[2 b b b] false 1747937531343998314.0000000000}] got []
    fetcher_mvcc_test.go:185: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/9db56821b86748e0fc537f3d515778f0/logTestRowFetcherMVCCMetadata177548470
--- FAIL: TestRowFetcherMVCCMetadata (0.71s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

Jira issue: CRDB-50912
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. branch-master Failures and bugs on the master branch. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels May 22, 2025
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries May 22, 2025
@yuzefovich yuzefovich removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label May 22, 2025
@yuzefovich yuzefovich mentioned this issue May 22, 2025
Merged
@yuzefovich
Copy link
Member

yuzefovich commented May 22, 2025 •
edited
Loading

This one occasionally fails with buffered writes enabled (with different metamorphic values for lock reliability settings).

The test performs a handful of explicit write transactions that leak their commit timestamp via SELECT cluster_logical_timestamp(); as the last stmt. I've observed a couple failure modes:

-- after first txn
    fetcher_mvcc_test.go:157: expected [{[1 a a a] false 1747944641272391679.0000000000} {[2 b b b] false 1747944641272391679.0000000000}] got []
-- after second txn
    fetcher_mvcc_test.go:171: expected [{[1 NULL NULL NULL] false 1747944842584579084.0000000000} {[2 b b NULL] false 1747944842584579084.0000000000}] got [{[1 a a a] false 1747944842572915984.0000000000} {[2 b b b] false 1747944842572915984.0000000000}]

The test reads the data directly from the storage engine, via MVCC Iterator, and we block there until we see no intents. We might need to adjust the retry loop in slurpUserDataKVs somehow, to account for different behavior with buffered writes.

@yuzefovich yuzefovich self-assigned this May 23, 2025
@yuzefovich yuzefovich moved this from Triage to Active in SQL Queries May 23, 2025
@craig craig bot closed this as completed in faeec16 May 23, 2025
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team target-release-25.3.0
Projects
SQL Queries
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

row/fetcher: clean up and harden TestRowFetcherMVCCMetadata yuzefovich/cockroach
2 participants
@yuzefovich @cockroach-teamcity