Skip to content

sql/triggers: add triggers to the random schema workload #146580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dikshant opened this issue May 12, 2025 · 2 comments · May be fixed by #147210
Open

sql/triggers: add triggers to the random schema workload #146580

dikshant opened this issue May 12, 2025 · 2 comments · May be fixed by #147210
Assignees
@Dedej-Bergin
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-1 Issues/test failures with a fix SLA of 1 month T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@dikshant
Copy link

dikshant commented May 12, 2025 •
edited by exalate-issue-sync bot
Loading

We should add Triggers to the random schema workload so we can test cross interaction with other DDL features.

Jira issue: CRDB-50606

Epic CRDB-42942
@dikshant dikshant added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) A-sql-trigger Triggers and Trigger Functions labels May 12, 2025
@Dedej-Bergin Dedej-Bergin added T-sql-queries SQL Queries Team and removed T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels May 13, 2025
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries May 13, 2025
@Dedej-Bergin
Copy link
Contributor

When adding a new declarative schema changer statement, part of our process is to add testing for it to the random schema changer workload. Reach out to the foundations team if any help is needed.

@rimadeodhar rimadeodhar added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-queries SQL Queries Team A-sql-trigger Triggers and Trigger Functions labels May 13, 2025
@rytaft rytaft removed this from SQL Queries May 13, 2025
@rimadeodhar
Copy link
Collaborator

Moving this back to sql foundations team as the issues being discovered in #142370 seem to indicate a big gap in testing coverage for dependencies in triggers. @Dedej-Bergin: I have assigned it to you for now as part of oncall. Thanks!

@rimadeodhar rimadeodhar added the P-1 Issues/test failures with a fix SLA of 1 month label May 13, 2025
Dedej-Bergin added a commit to Dedej-Bergin/cockroach that referenced this issue May 23, 2025
@Dedej-Bergin
sql/workload: add triggers to the random schema workload
7205c40 
Added coverage for `CREATE TRIGGER` and `DROP TRIGGER` to
the Random Schema Changer Workload.

Fixes: cockroachdb#146580
Epic: CRDB-42942
Release note: none
@Dedej-Bergin Dedej-Bergin linked a pull request May 23, 2025 that will close this issue
Draft
Dedej-Bergin added a commit to Dedej-Bergin/cockroach that referenced this issue May 23, 2025
@Dedej-Bergin
sql/workload: add triggers to the random schema workload
c67c300 
Added coverage for `CREATE TRIGGER` and `DROP TRIGGER` to
the Random Schema Changer Workload.

Fixes: cockroachdb#146580
Epic: CRDB-42942
Release note: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dedej-Bergin Dedej-Bergin

Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-1 Issues/test failures with a fix SLA of 1 month T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql/workload: add triggers to the random schema workload Dedej-Bergin/cockroach
3 participants
@dikshant @rimadeodhar @Dedej-Bergin