Skip to content

PR: Fix several bugs with button's title (#19073),breaks Buttons custom fonts style in cocos studio #19258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sonyps5201314 opened this issue Dec 20, 2018 · 2 comments
Assignees
Milestone

Comments

@sonyps5201314
Copy link

sonyps5201314 commented Dec 20, 2018

  • cocos2d-x version:git v3 latest
  • devices test on:win32
  • developing environments
    • VS version:vs2017 15.9.4
      Steps to Reproduce:
      cocos studio中的样子:
      image
      test_bug.zip
  1. 下载附件2
    cpp-empty-test.zip
    ,直接编译运行看到结果,看到出问题的样子(大小缩小了):
    image

2.撤销该提交的更改(UIButton.h,UIButton.cpp),重新编译cocos及程序,就看到正确的样子了。
image

官方你们说该怎样整?官方升级cocos studio,还是开放cocos studio的源代码,还是修改cocos2dx源代码以修复本问题?

English:
What cocos studio looks like:

  1. Download attachment 2, compile and run directly to see the result, and see what the problem looks like (the size is reduced) :
  2. Undo the submitted changes(UIButton.h,UIButton.cpp) and recompile cocos and the program, and you will see the correct appearance.
    What do you say the authorities do?Will you officially upgrade cocos studio, open the source code of cocos studio, or modify the source code of cocos2dx to fix this problem?

reference linking:
#19253

PR: http://github.com/cocos2d/cocos2d-x/pull/19073

@PatriceJiang PatriceJiang changed the title 2018/9/29提交的Fix several bugs with button's title (#19073),会导致无法正确支持cocos studio中的Button使用自定义字体 PR: Fix several bugs with button's title (#19073),breaks Buttons custom fonts style in cocos studio Dec 21, 2018
@PatriceJiang PatriceJiang self-assigned this Dec 21, 2018
@PatriceJiang PatriceJiang added this to the 3.17.1 milestone Dec 21, 2018
@PatriceJiang
Copy link
Contributor

@sonyps5201314 please check if this issue fixed with #19260

@sonyps5201314
Copy link
Author

测试了,的确是修复了,感谢!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants