From 41ae413df4a72e1a742eaeacbb9d2e02ded6fd66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Mei=C3=9Fner?= Date: Thu, 3 Nov 2022 10:31:15 +0100 Subject: [PATCH 1/3] Fix #90 - booleans in subnet module aren't working Camelize key with no uppercase first letter. --- plugins/module_utils/phpipam_helper.py | 2 +- tests/test_playbooks/subnet.yml | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/plugins/module_utils/phpipam_helper.py b/plugins/module_utils/phpipam_helper.py index 4533a7c..d1bf84c 100644 --- a/plugins/module_utils/phpipam_helper.py +++ b/plugins/module_utils/phpipam_helper.py @@ -341,7 +341,7 @@ def _phpipam_spec_helper(self, spec): ansible_invisible = value.get('invisible', False) if 'phpipam_name' not in phpipam_value and '_' in key: - phpipam_value['phpipam_name'] = inflection.camelize(key) + phpipam_value['phpipam_name'] = inflection.camelize(key, uppercase_first_letter=False) if phpipam_type == 'entity': argument_value['type'] = 'str' diff --git a/tests/test_playbooks/subnet.yml b/tests/test_playbooks/subnet.yml index 75f2e94..69f3aad 100644 --- a/tests/test_playbooks/subnet.yml +++ b/tests/test_playbooks/subnet.yml @@ -19,6 +19,21 @@ name: create subnet again, no change subnet: "{{ base_subnet_data }}" + - name: set booleans + include: tasks/subnet.yml + vars: + name: set booleans + override: + show_as_name: Yes + dns_recursive: Yes + dns_records: Yes + allow_requests: Yes + ping_subnet: Yes + discover_subnet: Yes + is_folder: Yes + is_full: Yes + subnet: "{{ base_subnet_data | combine(override) }}" + - name: delete subnet include: tasks/subnet.yml vars: From e702a20565c7693eb6c80f7a292201df5cda4fea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Mei=C3=9Fner?= Date: Thu, 3 Nov 2022 11:09:07 +0100 Subject: [PATCH 2/3] fix test values --- tests/test_playbooks/subnet.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_playbooks/subnet.yml b/tests/test_playbooks/subnet.yml index 69f3aad..5ba2338 100644 --- a/tests/test_playbooks/subnet.yml +++ b/tests/test_playbooks/subnet.yml @@ -30,8 +30,8 @@ allow_requests: Yes ping_subnet: Yes discover_subnet: Yes - is_folder: Yes - is_full: Yes + is_folder: No + is_full: No subnet: "{{ base_subnet_data | combine(override) }}" - name: delete subnet From e5305d1412105d477454fab5a2a03abc1f353e1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Mei=C3=9Fner?= Date: Thu, 3 Nov 2022 20:31:21 +0100 Subject: [PATCH 3/3] add changelog entry --- changelogs/fragments/ booleans_in_subnet_module_not_working.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/ booleans_in_subnet_module_not_working.yml diff --git a/changelogs/fragments/ booleans_in_subnet_module_not_working.yml b/changelogs/fragments/ booleans_in_subnet_module_not_working.yml new file mode 100644 index 0000000..5a74e0d --- /dev/null +++ b/changelogs/fragments/ booleans_in_subnet_module_not_working.yml @@ -0,0 +1,2 @@ +bugfixes: + - fix \#90 - booleans in subnet module aren't working