Skip to content

Commit dd37cfb

Browse files
bradfitzcodebien
authored andcommitted
dashboard: update Dragonfly tip policy for ABI change, add release builder
From golang/go#34958 (comment) : > Go's DragonFly support policy is that we support the latest stable > release primarily, but also try to keep DragonFly master passing, in > prep for it to become the latest stable release. > > But that does mean we need one more builder at the moment. Updates golang/go#34958 Updates golang/go#23060 Change-Id: I84be7c64eac593dee2252c397f9529deea13605a Reviewed-on: https://go-review.googlesource.com/c/build/+/202478 Reviewed-by: Tobias Klauser <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]>
1 parent 615fbf3 commit dd37cfb

File tree

2 files changed

+25
-1
lines changed

2 files changed

+25
-1
lines changed

dashboard/builders.go

+17-1
Original file line numberDiff line numberDiff line change
@@ -331,6 +331,16 @@ var Hosts = map[string]*HostConfig{
331331
env: []string{"GOROOT_BOOTSTRAP=/usr/pkg/go112"},
332332
OwnerGithub: "bsiegert",
333333
},
334+
// Our DragonFly builder doesn't yet run on GCE
335+
// (golang.org/issue/23060), so @bradfitz currently runs the
336+
// release version at home, and @tdfbsd runs one somewhere
337+
// running the bleeding edge version.
338+
"host-dragonfly-amd64-bradfitz": &HostConfig{
339+
IsReverse: true,
340+
ExpectNum: 1,
341+
env: []string{"GOROOT_BOOTSTRAP=/usr/local/go"},
342+
OwnerGithub: "bradfitz",
343+
},
334344
"host-dragonfly-amd64-tdfbsd": &HostConfig{
335345
IsReverse: true,
336346
ExpectNum: 1,
@@ -2214,9 +2224,15 @@ func init() {
22142224
// (https://golang.org/issue/32836)
22152225
return false
22162226
}
2217-
return defaultBuildsRepoPolicy(repo, branch, goBranch)
2227+
return atLeastGo1(goBranch, 14) && defaultBuildsRepoPolicy(repo, branch, goBranch)
22182228
},
22192229
})
2230+
addBuilder(BuildConfig{
2231+
Name: "dragonfly-amd64-5_6",
2232+
HostType: "host-dragonfly-amd64-bradfitz",
2233+
shouldRunDistTest: noTestDir,
2234+
SkipSnapshot: true,
2235+
})
22202236
addBuilder(BuildConfig{
22212237
Name: "freebsd-arm-paulzhol",
22222238
HostType: "host-freebsd-arm-paulzhol",

dashboard/builders_test.go

+8
Original file line numberDiff line numberDiff line change
@@ -524,6 +524,14 @@ func TestBuilderConfig(t *testing.T) {
524524
// that'll never be fixed.
525525
{b("[email protected]", "net"), none},
526526
{b("[email protected]", "net"), none},
527+
528+
{b("dragonfly-amd64", "go"), onlyPost},
529+
{b("dragonfly-amd64", "net"), onlyPost},
530+
{b("[email protected]", "net"), none}, // Dragonfly ABI changes only supported by Go 1.14+
531+
{b("[email protected]", "go"), none}, // Dragonfly ABI changes only supported by Go 1.14+
532+
{b("dragonfly-amd64-5_6", "go"), onlyPost},
533+
{b("dragonfly-amd64-5_6", "net"), onlyPost},
534+
{b("[email protected]", "net"), onlyPost},
527535
}
528536
for _, tt := range tests {
529537
t.Run(tt.br.testName, func(t *testing.T) {

0 commit comments

Comments
 (0)