Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insight] PHP code should follow PSR-1 basic coding standard - in Symfony/src/…/Handler/UtilityHandler.php, line 109 #18

Open
tzikis opened this issue Jan 9, 2015 · 1 comment

Comments

@tzikis
Copy link
Member

tzikis commented Jan 9, 2015

in Symfony/src/Codebender/CompilerBundle/Handler/UtilityHandler.php, line 109

Method names should be declared in camelCase. You should rename this class to comply with PSR-1.

     *
     * \param string $directory The directory to search for files.
     * \param mixed $extensions An array of strings, the extensions to look for.
     * \return A list of files that have the appropriate extension.
     */
    function get_files_by_extension($directory, $extensions)
    {
        if (is_string($extensions))
            $extensions = array($extensions);

        $files = array();

Posted from SensioLabsInsight

@tzikis
Copy link
Member Author

tzikis commented Jan 9, 2015

Actually, nevermind the actual error (it's easily fixable). I actually can't find any place (by searching project-wide with PHP Storm) where it's being called. Is this used at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant