Skip to content

Commit a0fe538

Browse files
lzchencodeboten
authored andcommitted
[WIP] Views API Prototype (open-telemetry#596)
1 parent 6789724 commit a0fe538

File tree

1 file changed

+6
-23
lines changed

1 file changed

+6
-23
lines changed

Diff for: exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py

+6-23
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,10 @@ def setUp(self):
3232
set_meter_provider(metrics.MeterProvider())
3333
self._meter = get_meter_provider().get_meter(__name__)
3434
self._test_metric = self._meter.create_metric(
35-
"testname",
36-
"testdesc",
37-
"unit",
38-
int,
39-
metrics.Counter,
40-
["environment"],
35+
"testname", "testdesc", "unit", int, metrics.Counter,
4136
)
4237
labels = {"environment": "staging"}
43-
self._labels_key = metrics.get_labels_as_key(labels)
38+
self._labels_key = metrics.get_dict_as_key(labels)
4439

4540
self._mock_registry_register = mock.Mock()
4641
self._registry_register_patch = mock.patch(
@@ -78,15 +73,10 @@ def test_export(self):
7873
def test_counter_to_prometheus(self):
7974
meter = get_meter_provider().get_meter(__name__)
8075
metric = meter.create_metric(
81-
"test@name",
82-
"testdesc",
83-
"unit",
84-
int,
85-
metrics.Counter,
86-
["environment@", "os"],
76+
"test@name", "testdesc", "unit", int, metrics.Counter,
8777
)
8878
labels = {"environment@": "staging", "os": "Windows"}
89-
key_labels = metrics.get_labels_as_key(labels)
79+
key_labels = metrics.get_dict_as_key(labels)
9080
aggregator = SumAggregator()
9181
aggregator.update(123)
9282
aggregator.take_checkpoint()
@@ -117,7 +107,7 @@ def test_invalid_metric(self):
117107
"tesname", "testdesc", "unit", int, StubMetric
118108
)
119109
labels = {"environment": "staging"}
120-
key_labels = metrics.get_labels_as_key(labels)
110+
key_labels = metrics.get_dict_as_key(labels)
121111
record = MetricRecord(metric, key_labels, None)
122112
collector = CustomCollector("testprefix")
123113
collector.add_metrics_data([record])
@@ -143,15 +133,8 @@ def __init__(
143133
unit: str,
144134
value_type,
145135
meter,
146-
label_keys,
147136
enabled: bool = True,
148137
):
149138
super().__init__(
150-
name,
151-
description,
152-
unit,
153-
value_type,
154-
meter,
155-
label_keys=label_keys,
156-
enabled=enabled,
139+
name, description, unit, value_type, meter, enabled=enabled,
157140
)

0 commit comments

Comments
 (0)