opentelemetry-instrumentation-flask fix recording bug

Alex Boten · Alex Boten · commit c6afbd08b982 · 2022-03-15T08:34:04.000-07:00
Fix open-telemetry#998
diff --git a/instrumentation/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py b/instrumentation/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
@@ -153,7 +153,7 @@ def _start_response(status, response_headers, *args, **kwargs):
                     otel_wsgi.add_response_attributes(
                         span, status, response_headers
                     )
-                    if span.kind == trace.SpanKind.SERVER:
+                    if span.is_recording() and span.kind == trace.SpanKind.SERVER:
                         otel_wsgi.add_custom_response_headers(
                             span, response_headers
                         )
@@ -204,7 +204,7 @@ def _before_request():
                 ] = flask.request.url_rule.rule
             for key, value in attributes.items():
                 span.set_attribute(key, value)
-            if span.kind == trace.SpanKind.SERVER:
+            if span.is_recording() and span.kind == trace.SpanKind.SERVER:
                 otel_wsgi.add_custom_request_headers(
                     span, flask_request_environ
                 )

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ def _start_response(status, response_headers, args, *kwargs):`
`153`	`153`	`otel_wsgi.add_response_attributes(`
`154`	`154`	`span, status, response_headers`
`155`	`155`	`)`
`156`		`- if span.kind == trace.SpanKind.SERVER:`
	`156`	`+ if span.is_recording() and span.kind == trace.SpanKind.SERVER:`
`157`	`157`	`otel_wsgi.add_custom_response_headers(`
`158`	`158`	`span, response_headers`
`159`	`159`	`)`
`@@ -204,7 +204,7 @@ def _before_request():`
`204`	`204`	`] = flask.request.url_rule.rule`
`205`	`205`	`for key, value in attributes.items():`
`206`	`206`	`span.set_attribute(key, value)`
`207`		`- if span.kind == trace.SpanKind.SERVER:`
	`207`	`+ if span.is_recording() and span.kind == trace.SpanKind.SERVER:`
`208`	`208`	`otel_wsgi.add_custom_request_headers(`
`209`	`209`	`span, flask_request_environ`
`210`	`210`	`)`