Skip to content

Commit c2a22ec

Browse files
committed
fix: correct for new execGitNode syntax (nodejs#433)
1 parent b59a4ca commit c2a22ec

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

lib/update-v8/commitUpdate.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module.exports = function() {
77
title: 'Commit V8 update',
88
task: async(ctx) => {
99
const newV8Version = util.getNodeV8Version(ctx.nodeDir).join('.');
10-
await ctx.execGitNode('add', 'deps/v8');
10+
await ctx.execGitNode('add', ['deps/v8']);
1111
const moreArgs = [];
1212
let message;
1313
if (ctx.minor) {
@@ -21,7 +21,7 @@ module.exports = function() {
2121
} else {
2222
message = `deps: update V8 to ${newV8Version}`;
2323
}
24-
await ctx.execGitNode('commit', '-m', message, ...moreArgs);
24+
await ctx.execGitNode('commit', ['-m', message, ...moreArgs]);
2525
},
2626
skip: (ctx) => ctx.skipped
2727
};

lib/update-v8/updateVersionNumbers.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,16 @@ function bumpNodeModule() {
2929
await updateModuleVersion(ctx.nodeDir, newModuleVersion, v8Version);
3030
await ctx.execGitNode(
3131
'add',
32-
'doc/abi_version_registry.json',
33-
'src/node_version.h'
32+
['doc/abi_version_registry.json', 'src/node_version.h']
3433
);
3534
await ctx.execGitNode(
3635
'commit',
37-
'-m',
38-
getCommitTitle(newModuleVersion),
39-
'-m',
40-
getCommitBody(v8Version)
36+
[
37+
'-m',
38+
getCommitTitle(newModuleVersion),
39+
'-m',
40+
getCommitBody(v8Version)
41+
]
4142
);
4243
},
4344
skip: (ctx) => !ctx.versionBump
@@ -103,11 +104,10 @@ function resetEmbedderString() {
103104
commonGypiPath,
104105
commonGypi.replace(embedderRegex, embedderString)
105106
);
106-
await ctx.execGitNode('add', 'common.gypi');
107+
await ctx.execGitNode('add', ['common.gypi']);
107108
await ctx.execGitNode(
108109
'commit',
109-
'-m',
110-
'build: reset embedder string to "-node.0"'
110+
['-m', 'build: reset embedder string to "-node.0"']
111111
);
112112
} else {
113113
return task.skip('Embedder version is already 0');

0 commit comments

Comments
 (0)