Skip to content

Commit 26dccb3

Browse files
authoredJun 10, 2024··
release 3.6.3 (#4388)
1 parent d3dced1 commit 26dccb3

File tree

7 files changed

+36
-21
lines changed

7 files changed

+36
-21
lines changed
 

‎CHANGELOG.md

+19
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,22 @@
1+
## 3.6.3
2+
3+
❤️ Thanks all to those who contributed to make this release! ❤️
4+
5+
🛩️ *Features*
6+
* feat(plugin): coverage with WebDriver - devtools (#4349) - by @KobeNguyent
7+
![Screenshot 2024-05-16 at 16 49 20](https://github.com/codeceptjs/CodeceptJS/assets/7845001/a02f0f99-ac78-4d3f-9774-2cb51c688025)
8+
9+
🐛 *Bug Fixes*
10+
* fix(cli): stale process (#4367) - by @Horsty80 @kobenguyent
11+
* fix(runner): screenshot error in beforeSuite/AfterSuite (#4385) - by @kobenguyent
12+
* fix(cli): gherkin command init with TypeScript (#4366) - by @andonary
13+
* fix(webApi): error message of dontSeeCookie (#4357) - by @a-stankevich
14+
15+
📖 *Documentation*
16+
* fix(doc): Expect helper is not described correctly (#4370) - by @kobenguyent
17+
* fix(docs): some strange characters (#4387) - by @kobenguyent
18+
* fix: Puppeteer helper doc typo (#4369) - by @yoannfleurydev
19+
120
## 3.6.2
221

322
❤️ Thanks all to those who contributed to make this release! ❤️

‎lib/command/gherkin/init.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ module.exports = function (genPath) {
7070
}
7171

7272
config.gherkin = {
73-
features: "./features/*.feature",
73+
features: './features/*.feature',
7474
steps: [`./step_definitions/steps.${extension}`],
7575
};
7676

‎lib/plugin/retryTo.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,7 @@ module.exports = function (config) {
104104
recorder.session.restore(`retryTo ${tries}`);
105105
if (tries <= maxTries) {
106106
debug(`Error ${err}... Retrying`);
107-
recorder.add(`retryTo ${tries}`, () =>
108-
setTimeout(tryBlock, pollInterval)
109-
);
107+
recorder.add(`retryTo ${tries}`, () => setTimeout(tryBlock, pollInterval));
110108
} else {
111109
// if maxTries reached
112110
handleRetryException(err);

‎package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "codeceptjs",
3-
"version": "3.6.2",
3+
"version": "3.6.3",
44
"description": "Supercharged End 2 End Testing Framework for NodeJS",
55
"keywords": [
66
"acceptance",
@@ -179,4 +179,4 @@
179179
"strict": false
180180
}
181181
}
182-
}
182+
}

‎test/acceptance/retryTo_test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,4 @@ Scenario('Should succeed at the third attempt @plugin', async () => {
3333
await retryTo(async (tryNum) => {
3434
if (tryNum < 2) throw new Error('Custom pluginRetryTo Error');
3535
}, 3);
36-
});
36+
});

‎test/data/sandbox/test.scenario-stale.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Feature('Scenario should not be staling');
33
const SHOULD_NOT_STALE = 'should not stale scenario error';
44

55
Scenario('Rejected promise should not stale the process', async () => {
6-
await new Promise((_resolve, reject) => setTimeout(reject(new Error(SHOULD_NOT_STALE)), 500));
6+
await new Promise((_resolve, reject) => { setTimeout(reject(new Error(SHOULD_NOT_STALE)), 500); });
77
});
88

99
Scenario('Should handle throw inside synchronous and terminate gracefully', () => {
@@ -17,6 +17,6 @@ Scenario('Should throw, retry and keep failing', async () => {
1717
setTimeout(() => {
1818
throw new Error(SHOULD_NOT_STALE);
1919
}, 500);
20-
await new Promise((resolve) => setTimeout(resolve, 300));
20+
await new Promise((resolve) => { setTimeout(resolve, 300); });
2121
throw new Error(SHOULD_NOT_STALE);
2222
}).retry(2);

‎test/plugin/plugin_test.js

+10-12
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ describe('CodeceptJS plugin', function () {
3434

3535
it('should failed before the retryTo instruction', (done) => {
3636
exec(`${config_run_config('codecept.Playwright.retryTo.js', 'Should be succeed')} --verbose`, (err, stdout) => {
37-
expect(stdout).toContain('locator.waitFor: Timeout 1000ms exceeded.'),
38-
expect(stdout).toContain('[1] Error | Error: element (.nothing) still not visible after 1 sec'),
37+
expect(stdout).toContain('locator.waitFor: Timeout 1000ms exceeded.');
38+
expect(stdout).toContain('[1] Error | Error: element (.nothing) still not visible after 1 sec');
3939
expect(err).toBeTruthy();
4040
done();
4141
});
@@ -72,15 +72,13 @@ describe('CodeceptJS plugin', function () {
7272
});
7373

7474
it('should retry to failure', (done) => {
75-
exec(
76-
`${config_run_config('codecept.Playwright.retryTo.js', 'Should fail after reached max retries')} --verbose`, (err, stdout) => {
77-
const lines = stdout.split('\n');
78-
expect(lines).toEqual(
79-
expect.arrayContaining([expect.stringContaining('Custom pluginRetryTo Error')])
80-
);
81-
expect(err).toBeTruthy();
82-
done();
83-
}
84-
);
75+
exec(`${config_run_config('codecept.Playwright.retryTo.js', 'Should fail after reached max retries')} --verbose`, (err, stdout) => {
76+
const lines = stdout.split('\n');
77+
expect(lines).toEqual(
78+
expect.arrayContaining([expect.stringContaining('Custom pluginRetryTo Error')]),
79+
);
80+
expect(err).toBeTruthy();
81+
done();
82+
});
8583
});
8684
});

0 commit comments

Comments
 (0)
Please sign in to comment.