From da1c33e9cb25959e30ac40a1cc165eaa97bc9d3b Mon Sep 17 00:00:00 2001
From: Arthur Stankevich <a-stankevich@users.noreply.github.com>
Date: Tue, 21 May 2024 12:12:09 +0200
Subject: [PATCH 1/2] Fixed error message for dontSeeCookie()
---
lib/helper/Nightmare.js | 2 +-
lib/helper/Playwright.js | 2 +-
lib/helper/Protractor.js | 2 +-
lib/helper/Puppeteer.js | 2 +-
lib/helper/WebDriver.js | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/helper/Nightmare.js b/lib/helper/Nightmare.js
index ff180135c..359a5c82e 100644
--- a/lib/helper/Nightmare.js
+++ b/lib/helper/Nightmare.js
@@ -989,7 +989,7 @@ class Nightmare extends Helper {
*/
async dontSeeCookie(name) {
const res = await this.browser.cookies.get(name);
- truth(`cookie ${name}`, 'to be set').negate(res);
+ truth(`cookie ${name}`, 'not to be set').negate(res);
}
/**
diff --git a/lib/helper/Playwright.js b/lib/helper/Playwright.js
index fbb24ed9d..00ff5e697 100644
--- a/lib/helper/Playwright.js
+++ b/lib/helper/Playwright.js
@@ -1702,7 +1702,7 @@ class Playwright extends Helper {
*/
async dontSeeCookie(name) {
const cookies = await this.browserContext.cookies();
- empty(`cookie ${name} to be set`).assert(cookies.filter(c => c.name === name));
+ empty(`cookie ${name} not to be set`).assert(cookies.filter(c => c.name === name));
}
/**
diff --git a/lib/helper/Protractor.js b/lib/helper/Protractor.js
index 48f3eef85..a9b4c0e89 100644
--- a/lib/helper/Protractor.js
+++ b/lib/helper/Protractor.js
@@ -1119,7 +1119,7 @@ class Protractor extends Helper {
* {{> dontSeeCookie }}
*/
async dontSeeCookie(name) {
- return this.browser.manage().getCookie(name).then(res => truth(`cookie ${name}`, 'to be set').negate(res));
+ return this.browser.manage().getCookie(name).then(res => truth(`cookie ${name}`, 'not to be set').negate(res));
}
/**
diff --git a/lib/helper/Puppeteer.js b/lib/helper/Puppeteer.js
index 1187561e2..33de55d4c 100644
--- a/lib/helper/Puppeteer.js
+++ b/lib/helper/Puppeteer.js
@@ -1528,7 +1528,7 @@ class Puppeteer extends Helper {
*/
async dontSeeCookie(name) {
const cookies = await this.page.cookies();
- empty(`cookie ${name} to be set`).assert(cookies.filter(c => c.name === name));
+ empty(`cookie ${name} not to be set`).assert(cookies.filter(c => c.name === name));
}
/**
diff --git a/lib/helper/WebDriver.js b/lib/helper/WebDriver.js
index 57c82e2b1..ba97de201 100644
--- a/lib/helper/WebDriver.js
+++ b/lib/helper/WebDriver.js
@@ -1731,7 +1731,7 @@ class WebDriver extends Helper {
*/
async dontSeeCookie(name) {
const cookie = await this.browser.getCookies([name]);
- return truth(`cookie ${name}`, 'to be set').negate(cookie);
+ return truth(`cookie ${name}`, 'not to be set').negate(cookie);
}
/**
From 3da212561dba24d114adb4ffccf73d612d7bd7c0 Mon Sep 17 00:00:00 2001
From: Arthur Stankevich <a-stankevich@users.noreply.github.com>
Date: Wed, 22 May 2024 16:55:20 +0200
Subject: [PATCH 2/2] Removed extra 'not' where negate() is used
---
lib/helper/Nightmare.js | 2 +-
lib/helper/Protractor.js | 2 +-
lib/helper/WebDriver.js | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/helper/Nightmare.js b/lib/helper/Nightmare.js
index 359a5c82e..ff180135c 100644
--- a/lib/helper/Nightmare.js
+++ b/lib/helper/Nightmare.js
@@ -989,7 +989,7 @@ class Nightmare extends Helper {
*/
async dontSeeCookie(name) {
const res = await this.browser.cookies.get(name);
- truth(`cookie ${name}`, 'not to be set').negate(res);
+ truth(`cookie ${name}`, 'to be set').negate(res);
}
/**
diff --git a/lib/helper/Protractor.js b/lib/helper/Protractor.js
index a9b4c0e89..48f3eef85 100644
--- a/lib/helper/Protractor.js
+++ b/lib/helper/Protractor.js
@@ -1119,7 +1119,7 @@ class Protractor extends Helper {
* {{> dontSeeCookie }}
*/
async dontSeeCookie(name) {
- return this.browser.manage().getCookie(name).then(res => truth(`cookie ${name}`, 'not to be set').negate(res));
+ return this.browser.manage().getCookie(name).then(res => truth(`cookie ${name}`, 'to be set').negate(res));
}
/**
diff --git a/lib/helper/WebDriver.js b/lib/helper/WebDriver.js
index ba97de201..57c82e2b1 100644
--- a/lib/helper/WebDriver.js
+++ b/lib/helper/WebDriver.js
@@ -1731,7 +1731,7 @@ class WebDriver extends Helper {
*/
async dontSeeCookie(name) {
const cookie = await this.browser.getCookies([name]);
- return truth(`cookie ${name}`, 'not to be set').negate(cookie);
+ return truth(`cookie ${name}`, 'to be set').negate(cookie);
}
/**