Fixed Download file error and updated README

Author: Kartikeya99

Diff for: README.md

@@ -102,7 +102,7 @@ Scenario('Compare CPU Usage Images', async (I) => {
 });
 ```
 The generated output and diff images can also be directly uploaded to AWS S3 by using the `upload` method which will upload both the output as well as diff image generated.
-The files will be uploaded to a folder named output inside of the bucket.
+The screenshot file will be uploaded to a folder named output and the diff file(if it exists) inside a folder named diff inside the bucket.
 ```
 I.upload("AccessKeyId", "secretAccessKey", "region", "bucketName", "baseImage");
 ```
@@ -112,6 +112,7 @@ Moreover, the base images can also be downloaded from S3 with the `download` met
 I.download("AccessKeyId", "secretAccessKey", "region", "bucketName", "baseImage");
 ```
 You will need to store these base images inside a folder named base inside the bucket.
+Make sure to give correct file type extensions to both the `I.upload` and `I.download` methods.
 
 
 

Diff for: index.js

@@ -3,7 +3,7 @@ const fs = require('fs');
 const assert = require('assert');
 const mkdirp = require('mkdirp');
 const getDirName = require('path').dirname;
-const AWS = require('aws-sdk');
+const AWS = require("aws-sdk");
 
 /**
  * Resemble.js helper class for CodeceptJS, this allows screen comparison
@@ -104,7 +104,7 @@ class ResembleHelper extends Helper {
      */
 
     async upload(accessKeyId, secretAccessKey, region, bucketName, baseImage) {
-        console.log("Entered upload");
+        console.log("Starting Upload... ");
         const s3 = new AWS.S3({
             accessKeyId: accessKeyId,
             secretAccessKey: secretAccessKey,
@@ -149,24 +149,22 @@ class ResembleHelper extends Helper {
      */
 
     async download(accessKeyId, secretAccessKey, region, bucketName, baseImage) {
-        console.log("Entered download");
-        const s3 = new AWS.S3({region: region});
+        console.log("Starting Download... ");
+        const s3 = new AWS.S3({
+            accessKeyId: accessKeyId,
+            secretAccessKey: secretAccessKey,
+            region: region
+        });
         const params = {
             Bucket: bucketName,
             Key: `base/${baseImage}`
         };
 
-        const outStream = fs.createWriteStream(this.config.baseFolder + baseImage);
-        const awsStream = s3.getObject(params, (uerr, data) => {
-            if(uerr) throw uerr;
-            console.log(`Base file downloaded successfully!`)
-        }).createReadStream();
-
-        awsStream.pipe(outStream);
-        awsStream.on('end', function() {
-            console.log("successfully Downloaded");
-        }).on('error', function() {
-            console.log("Some error occured while downloading");
+        s3.getObject(params, (err, data) => {
+            if(err) console.error(err);
+            console.log(this.config.baseFolder + baseImage);
+            fs.writeFileSync(this.config.baseFolder + baseImage, data.Body);
+            console.log(`Base Image Downloaded Successfully at ${this.config.baseFolder} as ${baseImage}`);
         });
     }