Problem with ScreenCompare with Playwright (#113)

tfr-ds · web-flow · commit e0fb25db8ed3 · 2023-01-02T20:36:49.000+05:30
* +Update resemblejs

* +Fix bug for element diff

* +Update package versions
diff --git a/index.js b/index.js
@@ -340,7 +340,8 @@ class ResembleHelper extends Helper {
       await this._download(awsC.accessKeyId, awsC.secretAccessKey, awsC.region, awsC.bucketName, baseImage, options);
     }
 
-    if (selector) {
+    // BoundingBox for Playwright not necessary
+    if (selector && !this.helpers['Playwright']) {
       options.boundingBox = await this._getBoundingBox(selector);
     }
     const misMatch = await this._fetchMisMatchPercentage(baseImage, options);

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,8 @@ class ResembleHelper extends Helper {`
`340`	`340`	`await this._download(awsC.accessKeyId, awsC.secretAccessKey, awsC.region, awsC.bucketName, baseImage, options);`
`341`	`341`	`}`
`342`	`342`
`343`		`- if (selector) {`
	`343`	`+ // BoundingBox for Playwright not necessary`
	`344`	`+ if (selector && !this.helpers['Playwright']) {`
`344`	`345`	`options.boundingBox = await this._getBoundingBox(selector);`
`345`	`346`	`}`
`346`	`347`	`const misMatch = await this._fetchMisMatchPercentage(baseImage, options);`