Skip to content

Commit 5f1fddd

Browse files
committed
Timeout errors should be fatal
Timeouts are slightly non-deterministic by their nature. So we should consider them fatal. They can still be useful, but should be for truly pathological cases since they are fatal, so I've upped the limit to 5 mintues.
1 parent 284fab5 commit 5f1fddd

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

lib/cc/engine/analyzers/analyzer_base.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ class Base
77
RESCUABLE_ERRORS = [
88
::CC::Engine::Analyzers::ParserError,
99
::Racc::ParseError,
10-
::Timeout::Error,
1110
]
1211

1312
def initialize(engine_config:)

lib/cc/engine/analyzers/command_line_runner.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ module CC
55
module Engine
66
module Analyzers
77
class CommandLineRunner
8-
DEFAULT_TIMEOUT = 20
8+
DEFAULT_TIMEOUT = 300
99

1010
def initialize(command, timeout = DEFAULT_TIMEOUT)
1111
@command = command

lib/cc/engine/analyzers/ruby/main.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class Main < CC::Engine::Analyzers::Base
1919
]
2020
DEFAULT_MASS_THRESHOLD = 18
2121
BASE_POINTS = 10_000
22-
TIMEOUT = 10
22+
TIMEOUT = 300
2323

2424
private
2525

0 commit comments

Comments
 (0)