Push images to Dockerhub instead of GCR (#343)

Author: dantevvp

.circleci/config.yml

@@ -25,25 +25,25 @@ jobs:
               circleci step halt
             fi
       - run: make image
-      - run: echo "$GCR_JSON_KEY" | docker login -u _json_key --password-stdin us.gcr.io
+      - run: echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
       - run:
-          name: Push image to GCR
+          name: Push image to Dockerhub
           command: |
-            docker tag $CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME \
-              us.gcr.io/code-climate/codeclimate-rubocop:b$CIRCLE_BUILD_NUM
-            docker push us.gcr.io/code-climate/codeclimate-rubocop:b$CIRCLE_BUILD_NUM
+            make release RELEASE_TAG="b$CIRCLE_BUILD_NUM"
+            make release RELEASE_TAG="$(echo $CIRCLE_BRANCH | grep -oP 'channel/\K[\w\-]+')"
 
 workflows:
   version: 2
   build_deploy:
     jobs:
       - test
       - release_images:
+          context: Quality
           requires:
             - test
           filters:
             branches:
               only: /master|channel\/[\w-]+/
 notify:
   webhooks:
-    - url: https://cc-slack-proxy.herokuapp.com/circle
+    - url: https://cc-slack-proxy.herokuapp.com/circle

Makefile

@@ -1,6 +1,11 @@
-.PHONY: image test docs bundle
+.PHONY: image test docs bundle release
 
 IMAGE_NAME ?= codeclimate/codeclimate-rubocop
+RELEASE_REGISTRY ?= codeclimate
+
+ifndef RELEASE_TAG
+override RELEASE_TAG = latest
+endif
 
 image:
 	docker build --rm -t $(IMAGE_NAME) .
@@ -19,4 +24,8 @@ bundle:
 	docker run --rm \
 	  --entrypoint /bin/sh \
 	  --volume $(PWD):/usr/src/app \
-	  $(IMAGE_NAME) -c "cd /usr/src/app && bundle $(BUNDLE_ARGS)"
+	  $(IMAGE_NAME) -c "cd /usr/src/app && bundle $(BUNDLE_ARGS)"
+
+release:
+	docker tag $(IMAGE_NAME) $(RELEASE_REGISTRY)/codeclimate-rubocop:$(RELEASE_TAG)
+	docker push $(RELEASE_REGISTRY)/codeclimate-rubocop:$(RELEASE_TAG)