Update rubocop to 1.46.0 (#340)

- General bundle update.
- Update the docs too.

Author: BrianHawley

Gemfile

@@ -5,7 +5,7 @@ source 'https://rubygems.org'
 gem "activesupport", require: false
 gem "parser"
 gem "pry", require: false
-gem "rubocop", "1.40.0", require: false
+gem "rubocop", "1.46.0", require: false
 gem "rubocop-i18n", require: false
 gem "rubocop-graphql", require: false
 gem "rubocop-minitest", require: false

Gemfile.lock

@@ -1,86 +1,89 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.4)
+    activesupport (7.0.4.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
     ast (2.4.2)
     coderay (1.1.3)
-    concurrent-ruby (1.1.10)
+    concurrent-ruby (1.2.2)
     diff-lcs (1.5.0)
     i18n (1.12.0)
       concurrent-ruby (~> 1.0)
     json (2.6.3)
     method_source (1.0.0)
-    minitest (5.16.3)
+    minitest (5.17.0)
     parallel (1.22.1)
-    parser (3.1.3.0)
+    parser (3.2.1.0)
       ast (~> 2.4.1)
-    pry (0.14.1)
+    pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    rack (3.0.2)
+    rack (3.0.4.1)
     rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.6.1)
+    regexp_parser (2.7.0)
     rexml (3.2.5)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
       rspec-expectations (~> 3.12.0)
       rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.0)
+    rspec-core (3.12.1)
       rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.0)
+    rspec-expectations (3.12.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.1)
+    rspec-mocks (3.12.3)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.0)
-    rubocop (1.40.0)
+    rubocop (1.46.0)
       json (~> 2.3)
       parallel (~> 1.10)
-      parser (>= 3.1.2.1)
+      parser (>= 3.2.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.23.0, < 2.0)
+      rubocop-ast (>= 1.26.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.24.0)
-      parser (>= 3.1.1.0)
-    rubocop-graphql (0.18.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.27.0)
+      parser (>= 3.2.1.0)
+    rubocop-capybara (2.17.1)
+      rubocop (~> 1.41)
+    rubocop-graphql (1.0.0)
       rubocop (>= 0.87, < 2)
     rubocop-i18n (3.0.0)
       rubocop (~> 1.0)
-    rubocop-minitest (0.25.0)
-      rubocop (>= 0.90, < 2.0)
-    rubocop-performance (1.15.1)
+    rubocop-minitest (0.28.0)
+      rubocop (>= 1.39, < 2.0)
+    rubocop-performance (1.16.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.17.3)
+    rubocop-rails (2.18.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.16.0)
+    rubocop-rspec (2.18.1)
       rubocop (~> 1.33)
+      rubocop-capybara (~> 2.17)
     rubocop-sequel (0.3.4)
       rubocop (~> 1.0)
-    rubocop-shopify (2.10.1)
-      rubocop (~> 1.35)
-    rubocop-sorbet (0.6.11)
+    rubocop-shopify (2.12.0)
+      rubocop (~> 1.44)
+    rubocop-sorbet (0.7.0)
       rubocop (>= 0.90.0)
     rubocop-thread_safety (0.4.4)
       rubocop (>= 0.53.0)
     ruby-progressbar (1.11.0)
-    test-prof (1.1.0)
-    tzinfo (2.0.5)
+    test-prof (1.2.0)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.3.0)
+    unicode-display_width (2.4.2)
 
 PLATFORMS
   ruby
@@ -91,7 +94,7 @@ DEPENDENCIES
   pry
   rake
   rspec
-  rubocop (= 1.40.0)
+  rubocop (= 1.46.0)
   rubocop-graphql
   rubocop-i18n
   rubocop-minitest

config/contents/gemspec/development_dependencies.md

@@ -0,0 +1,63 @@
+Enforce that development dependencies for a gem are specified in
+`Gemfile`, rather than in the `gemspec` using
+`add_development_dependency`. Alternatively, using `EnforcedStyle:
+gemspec`, enforce that all dependencies are specified in `gemspec`,
+rather than in `Gemfile`.
+
+### Example: EnforcedStyle: Gemfile (default)
+    # Specify runtime dependencies in your gemspec,
+    # but all other dependencies in your Gemfile.
+
+    # bad
+    # example.gemspec
+    s.add_development_dependency "foo"
+
+    # good
+    # Gemfile
+    gem "foo"
+
+    # good
+    # gems.rb
+    gem "foo"
+
+    # good (with AllowedGems: ["bar"])
+    # example.gemspec
+    s.add_development_dependency "bar"
+
+### Example: EnforcedStyle: gems.rb
+    # Specify runtime dependencies in your gemspec,
+    # but all other dependencies in your Gemfile.
+    #
+    # Identical to `EnforcedStyle: Gemfile`, but with a different error message.
+    # Rely on Bundler/GemFilename to enforce the use of `Gemfile` vs `gems.rb`.
+
+    # bad
+    # example.gemspec
+    s.add_development_dependency "foo"
+
+    # good
+    # Gemfile
+    gem "foo"
+
+    # good
+    # gems.rb
+    gem "foo"
+
+    # good (with AllowedGems: ["bar"])
+    # example.gemspec
+    s.add_development_dependency "bar"
+
+### Example: EnforcedStyle: gemspec
+    # Specify all dependencies in your gemspec.
+
+    # bad
+    # Gemfile
+    gem "foo"
+
+    # good
+    # example.gemspec
+    s.add_development_dependency "foo"
+
+    # good (with AllowedGems: ["bar"])
+    # Gemfile
+    gem "bar"

config/contents/layout/class_structure.md

@@ -124,5 +124,3 @@ automatically.
       def some_private_method
       end
     end
-
-@see https://rubystyle.guide#consistent-classes

config/contents/layout/first_array_element_line_break.md

@@ -1,13 +1,46 @@
 Checks for a line break before the first element in a
 multi-line array.
 
-### Example:
+### Example: AllowMultilineFinalElement: false (default)
 
       # bad
       [ :a,
         :b]
 
+      # bad
+      [ :a, {
+        :b => :c
+      }]
+
+      # good
+      [:a, :b]
+
       # good
       [
         :a,
         :b]
+
+      # good
+      [
+        :a, {
+        :b => :c
+      }]
+
+### Example: AllowMultilineFinalElement: true
+
+      # bad
+      [ :a,
+        :b]
+
+      # good
+      [ :a, {
+        :b => :c
+      }]
+
+      # good
+      [
+        :a,
+        :b]
+
+      # good
+      [:a, :b]

config/contents/layout/first_hash_element_line_break.md

@@ -1,13 +1,52 @@
 Checks for a line break before the first element in a
 multi-line hash.
 
-### Example:
+### Example: AllowMultilineFinalElement: false (default)
 
       # bad
       { a: 1,
         b: 2}
 
+      # bad
+      { a: 1, b: {
+        c: 3
+      }}
+
+      # good
+      {
+        a: 1,
+        b: 2 }
+
+      # good
+      {
+        a: 1, b: {
+        c: 3
+      }}
+
+### Example: AllowMultilineFinalElement: true
+
+      # bad
+      { a: 1,
+        b: 2}
+
+      # bad
+      { a: 1,
+        b: {
+        c: 3
+      }}
+
+      # good
+      { a: 1, b: {
+        c: 3
+      }}
+
       # good
       {
         a: 1,
-        b: 2 }
+        b: 2 }
+
+      # good
+      {
+        a: 1, b: {
+        c: 3
+      }}

config/contents/layout/first_method_argument_line_break.md

@@ -1,17 +1,70 @@
 Checks for a line break before the first argument in a
 multi-line method call.
 
-### Example:
+### Example: AllowMultilineFinalElement: false (default)
 
       # bad
       method(foo, bar,
         baz)
 
+      # bad
+      method(foo, bar, {
+        baz: "a",
+        qux: "b",
+      })
+
       # good
       method(
         foo, bar,
         baz)
 
+      # good
+      method(
+        foo, bar, {
+        baz: "a",
+        qux: "b",
+      })
+
+      # ignored
+      method foo, bar,
+        baz
+
+### Example: AllowMultilineFinalElement: true
+
+      # bad
+      method(foo, bar,
+        baz)
+
+      # bad
+      method(foo,
+        bar,
+        {
+          baz: "a",
+          qux: "b",
+        }
+      )
+
+      # good
+      method(foo, bar, {
+        baz: "a",
+        qux: "b",
+      })
+
+      # good
+      method(
+        foo, bar,
+        baz)
+
+      # good
+      method(
+        foo,
+        bar,
+        {
+          baz: "a",
+          qux: "b",
+        }
+      )
+
       # ignored
       method foo, bar,
         baz