Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Commit 39100a2

Browse files
nmoinvazhugovk
nmoinvaz
and
hugovk
authored
Add CODECOV_NAME as default for name (#267)
Co-authored-by: Hugo <[email protected]>
1 parent 1f5f6b9 commit 39100a2

File tree

2 files changed

+35
-4
lines changed

2 files changed

+35
-4
lines changed

‎codecov/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -342,8 +342,8 @@ def main(*argv, **kwargs):
342342
basics.add_argument(
343343
"--name",
344344
"-n",
345-
default=None,
346-
help="Custom defined name of the upload. Visible in Codecov UI.",
345+
default=os.getenv("CODECOV_NAME"),
346+
help="Custom defined name of the upload. Visible in Codecov UI. Defaults to $CODECOV_NAME.",
347347
)
348348

349349
gcov = parser.add_argument_group(

‎tests/test.py

+33-2
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ def setUp(self):
8282
"DRONE_BUILD_LINK",
8383
"TRAVIS_REPO_SLUG",
8484
"CODECOV_TOKEN",
85+
"CODECOV_NAME",
8586
"APPVEYOR",
8687
"APPVEYOR_REPO_BRANCH",
8788
"APPVEYOR_BUILD_VERSION",
@@ -394,7 +395,13 @@ def test_gcov(self):
394395
# self.skipTest("Skipped, works on Travis only.")
395396

396397
def test_disable_detect(self):
397-
self.set_env(JENKINS_URL="a", GIT_BRANCH="b", GIT_COMMIT="c", CODECOV_TOKEN="d")
398+
self.set_env(
399+
JENKINS_URL="a",
400+
GIT_BRANCH="b",
401+
GIT_COMMIT="c",
402+
CODECOV_TOKEN="d",
403+
CODECOV_NAME="e",
404+
)
398405
self.fake_report()
399406
try:
400407
self.run_cli(disable="detect")
@@ -486,6 +493,7 @@ def test_ci_jenkins(self):
486493
GIT_COMMIT="c739768fcac68144a3a6d82305b9c4106934d31a",
487494
BUILD_NUMBER="41",
488495
CODECOV_TOKEN="token",
496+
CODECOV_NAME="name",
489497
)
490498
self.fake_report()
491499
res = self.run_cli()
@@ -498,6 +506,7 @@ def test_ci_jenkins(self):
498506
self.assertEqual(res["query"]["pr"], "")
499507
self.assertEqual(res["query"]["branch"], "master")
500508
self.assertEqual(res["codecov"].token, "token")
509+
self.assertEqual(res["codecov"].name, "name")
501510

502511
@unittest.skipUnless(os.getenv("JENKINS_URL"), "Skip Jenkins CI test")
503512
def test_ci_jenkins_env(self):
@@ -509,6 +518,7 @@ def test_ci_jenkins_env(self):
509518
ghprbPullId="1",
510519
BUILD_NUMBER="41",
511520
CODECOV_TOKEN="token",
521+
CODECOV_NAME="name",
512522
)
513523
self.fake_report()
514524
res = self.run_cli()
@@ -521,6 +531,7 @@ def test_ci_jenkins_env(self):
521531
self.assertEqual(res["query"]["pr"], "1")
522532
self.assertEqual(res["query"]["branch"], "master")
523533
self.assertEqual(res["codecov"].token, "token")
534+
self.assertEqual(res["codecov"].name, "name")
524535

525536
@unittest.skipUnless(os.getenv("JENKINS_URL"), "Skip Jenkins CI test")
526537
def test_ci_jenkins_blue_ocean(self):
@@ -531,6 +542,7 @@ def test_ci_jenkins_blue_ocean(self):
531542
CHANGE_ID="1",
532543
BUILD_NUMBER="41",
533544
CODECOV_TOKEN="token",
545+
CODECOV_NAME="name",
534546
)
535547
self.fake_report()
536548
res = self.run_cli()
@@ -543,6 +555,7 @@ def test_ci_jenkins_blue_ocean(self):
543555
self.assertEqual(res["query"]["pr"], "1")
544556
self.assertEqual(res["query"]["branch"], "master")
545557
self.assertEqual(res["codecov"].token, "token")
558+
self.assertEqual(res["codecov"].name, "name")
546559

547560
@unittest.skipUnless(
548561
os.getenv("CI") == "true"
@@ -585,6 +598,7 @@ def test_ci_codeship(self):
585598
CI_BUILD_URL="https://codeship.io/build/1",
586599
CI_COMMIT_ID="743b04806ea677403aa2ff26c6bdeb85005de658",
587600
CODECOV_TOKEN="token",
601+
CODECOV_NAME="name",
588602
)
589603
self.fake_report()
590604
res = self.run_cli()
@@ -597,6 +611,7 @@ def test_ci_codeship(self):
597611
self.assertEqual(res["query"]["pr"], "")
598612
self.assertEqual(res["query"]["branch"], "master")
599613
self.assertEqual(res["codecov"].token, "token")
614+
self.assertEqual(res["codecov"].name, "name")
600615

601616
@unittest.skipUnless(
602617
os.getenv("CI") == "true" and os.getenv("CIRCLECI") == "true",
@@ -638,6 +653,7 @@ def test_ci_buildkite(self):
638653
BUILDKITE_PROJECT_SLUG="owner/repo",
639654
BUILDKITE_COMMIT="d653b934ed59c1a785cc1cc79d08c9aaa4eba73b",
640655
CODECOV_TOKEN="token",
656+
CODECOV_NAME="name",
641657
)
642658
self.fake_report()
643659
res = self.run_cli()
@@ -649,6 +665,7 @@ def test_ci_buildkite(self):
649665
self.assertEqual(res["query"]["slug"], "owner/repo")
650666
self.assertEqual(res["query"]["branch"], "master")
651667
self.assertEqual(res["codecov"].token, "token")
668+
self.assertEqual(res["codecov"].name, "name")
652669

653670
@unittest.skipUnless(
654671
os.getenv("CI") == "true" and os.getenv("SEMAPHORE") == "true",
@@ -663,6 +680,7 @@ def test_ci_semaphore(self):
663680
SEMAPHORE_REPO_SLUG="owner/repo",
664681
REVISION="743b04806ea677403aa2ff26c6bdeb85005de658",
665682
CODECOV_TOKEN="token",
683+
CODECOV_NAME="name",
666684
)
667685
self.fake_report()
668686
res = self.run_cli()
@@ -686,6 +704,7 @@ def test_ci_drone(self):
686704
DRONE_BRANCH="master",
687705
DRONE_BUILD_LINK="https://drone.io/github/builds/1",
688706
CODECOV_TOKEN="token",
707+
CODECOV_NAME="name",
689708
)
690709
self.fake_report()
691710
res = self.run_cli()
@@ -696,6 +715,7 @@ def test_ci_drone(self):
696715
self.assertEqual(res["query"]["build"], "10")
697716
self.assertEqual(res["query"]["build_url"], "https://drone.io/github/builds/1")
698717
self.assertEqual(res["codecov"].token, "token")
718+
self.assertEqual(res["codecov"].name, "name")
699719

700720
@unittest.skipUnless(os.getenv("SHIPPABLE") == "true", "Skip Shippable CI test")
701721
def test_ci_shippable(self):
@@ -707,6 +727,7 @@ def test_ci_shippable(self):
707727
BUILD_URL="https://shippable.com/...",
708728
COMMIT="743b04806ea677403aa2ff26c6bdeb85005de658",
709729
CODECOV_TOKEN="token",
730+
CODECOV_NAME="name",
710731
)
711732
self.fake_report()
712733
res = self.run_cli()
@@ -718,6 +739,7 @@ def test_ci_shippable(self):
718739
self.assertEqual(res["query"]["slug"], "owner/repo")
719740
self.assertEqual(res["query"]["build_url"], "https://shippable.com/...")
720741
self.assertEqual(res["codecov"].token, "token")
742+
self.assertEqual(res["codecov"].name, "name")
721743

722744
# @unittest.skipUnless(os.getenv('CI') == "True" and os.getenv('APPVEYOR') == 'True', 'Skip AppVeyor CI test')
723745
@unittest.skip("Skip AppVeyor test")
@@ -734,6 +756,7 @@ def test_ci_appveyor(self):
734756
APPVEYOR_REPO_NAME="owner/repo",
735757
APPVEYOR_REPO_COMMIT="d653b934ed59c1a785cc1cc79d08c9aaa4eba73b",
736758
CODECOV_TOKEN="token",
759+
CODECOV_NAME="name",
737760
)
738761
self.fake_report()
739762
res = self.run_cli(file=self.filepath)
@@ -746,6 +769,7 @@ def test_ci_appveyor(self):
746769
self.assertEqual(res["query"]["slug"], "owner/repo")
747770
self.assertEqual(res["query"]["pr"], "1")
748771
self.assertEqual(res["codecov"].token, "token")
772+
self.assertEqual(res["codecov"].name, "name")
749773

750774
@unittest.skipUnless(
751775
os.getenv("CI") == "true" and os.getenv("WERCKER_GIT_BRANCH"),
@@ -759,6 +783,7 @@ def test_ci_wercker(self):
759783
WERCKER_GIT_REPOSITORY="repo",
760784
WERCKER_GIT_COMMIT="d653b934ed59c1a785cc1cc79d08c9aaa4eba73b",
761785
CODECOV_TOKEN="token",
786+
CODECOV_NAME="name",
762787
)
763788
self.fake_report()
764789
res = self.run_cli()
@@ -769,6 +794,7 @@ def test_ci_wercker(self):
769794
self.assertEqual(res["query"]["build"], "1399372237")
770795
self.assertEqual(res["query"]["slug"], "owner/repo")
771796
self.assertEqual(res["codecov"].token, "token")
797+
self.assertEqual(res["codecov"].name, "name")
772798

773799
@unittest.skipUnless(
774800
os.getenv("CI") == "true" and os.getenv("MAGNUM") == "true",
@@ -782,6 +808,7 @@ def test_ci_magnum(self):
782808
CI="true",
783809
CI_COMMIT="d653b934ed59c1a785cc1cc79d08c9aaa4eba73b",
784810
CODECOV_TOKEN="token",
811+
CODECOV_NAME="name",
785812
)
786813
self.fake_report()
787814
res = self.run_cli()
@@ -791,6 +818,7 @@ def test_ci_magnum(self):
791818
)
792819
self.assertEqual(res["query"]["build"], "1399372237")
793820
self.assertEqual(res["codecov"].token, "token")
821+
self.assertEqual(res["codecov"].name, "name")
794822

795823
@unittest.skipUnless(
796824
os.getenv("CI_SERVER_NAME", "").startswith("GitLab"), "Skip GitLab CI test"
@@ -805,6 +833,7 @@ def test_ci_gitlab_pre9(self):
805833
HOME="/",
806834
CI_PROJECT_DIR=os.getcwd().strip("/"),
807835
CODECOV_TOKEN="token",
836+
CODECOV_NAME="name",
808837
)
809838
self.fake_report()
810839
res = self.run_cli()
@@ -815,6 +844,7 @@ def test_ci_gitlab_pre9(self):
815844
self.assertEqual(res["query"]["build"], "1399372237")
816845
self.assertEqual(res["query"]["slug"], "owner/repo")
817846
self.assertEqual(res["codecov"].token, "token")
847+
self.assertEqual(res["codecov"].name, "name")
818848

819849
@unittest.skipUnless(
820850
os.getenv("CI_SERVER_NAME", "").startswith("GitLab"), "Skip GitLab CI test"
@@ -842,7 +872,7 @@ def test_ci_gitlab(self):
842872

843873
@unittest.skip("Skip CI None")
844874
def test_ci_none(self):
845-
self.set_env(CODECOV_TOKEN="token")
875+
self.set_env(CODECOV_TOKEN="token", CODECOV_NAME="name")
846876
self.fake_report()
847877
res = self.run_cli(
848878
build=10,
@@ -857,3 +887,4 @@ def test_ci_none(self):
857887
self.assertEqual(res["query"]["build"], "10")
858888
self.assertEqual(res["query"]["slug"], "owner/repo")
859889
self.assertEqual(res["codecov"].token, "token")
890+
self.assertEqual(res["codecov"].name, "name")

0 commit comments

Comments
 (0)